-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Integration Tests for CLI and Genesis #204
Add Integration Tests for CLI and Genesis #204
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #204 +/- ##
===========================================
- Coverage 83.60% 83.43% -0.17%
===========================================
Files 20 20
Lines 2300 2349 +49
===========================================
+ Hits 1923 1960 +37
- Misses 203 209 +6
- Partials 174 180 +6
Continue to review full report at Codecov.
|
In |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for your hard work,
could you include also genesis export/init integration test cases in this PR?
- add comments - refactor to meet convention - fix grammar mistakes
The integration tests for initializing and exporting genesis will be handled in the other PR. |
Description
closes: #191
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes