Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests for CLI and Genesis #204

Merged
merged 13 commits into from
Apr 14, 2021

Conversation

defihyung
Copy link
Contributor

@defihyung defihyung commented Mar 30, 2021

Description

closes: #191


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #204 (a584278) into develop (63b6a90) will decrease coverage by 0.16%.
The diff coverage is n/a.

❗ Current head a584278 differs from pull request most recent head 9352b3e. Consider uploading reports for the commit 9352b3e to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
- Coverage    83.60%   83.43%   -0.17%     
===========================================
  Files           20       20              
  Lines         2300     2349      +49     
===========================================
+ Hits          1923     1960      +37     
- Misses         203      209       +6     
- Partials       174      180       +6     
Impacted Files Coverage Δ
x/liquidity/keeper/invariants.go 58.78% <0.00%> (-0.82%) ⬇️
x/liquidity/keeper/liquidity_pool.go 77.92% <0.00%> (-0.67%) ⬇️
x/liquidity/types/params.go 100.00% <0.00%> (ø)
x/liquidity/keeper/genesis.go 80.95% <0.00%> (ø)
x/liquidity/types/swap.go 81.81% <0.00%> (+0.06%) ⬆️
x/liquidity/keeper/batch.go 90.90% <0.00%> (+0.28%) ⬆️
x/liquidity/keeper/swap.go 85.82% <0.00%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b6a90...9352b3e. Read the comment docs.

@defihyung
Copy link
Contributor Author

In Makefile, test-uinit and test-cover both have $(PACKAGES_NOSIMULATION) but don't exclude simulation testing so I excluded simulation testing when running .

@defihyung defihyung marked this pull request as ready for review April 9, 2021 01:45
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you for your hard work,
could you include also genesis export/init integration test cases in this PR?

- add comments
- refactor to meet convention
- fix grammar mistakes
@defihyung
Copy link
Contributor Author

The integration tests for initializing and exporting genesis will be handled in the other PR.

@defihyung defihyung requested a review from dongsam April 14, 2021 04:46
@dongsam dongsam merged commit 6e5940c into tendermint:develop Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Integration Tests for cli, genesis
2 participants