Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Suggestions for Swagger documentation QA (2.2.1) #221

Merged
merged 2 commits into from
Apr 14, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Apr 14, 2021

Description

Apply Suggestions for swagger QA from #206


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #221 (05ec829) into develop (3faf4e2) will not change coverage.
The diff coverage is n/a.

❗ Current head 05ec829 differs from pull request most recent head e04a75d. Consider uploading reports for the commit e04a75d to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #221   +/-   ##
========================================
  Coverage    83.43%   83.43%           
========================================
  Files           20       20           
  Lines         2349     2349           
========================================
  Hits          1960     1960           
  Misses         209      209           
  Partials       180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3faf4e2...e04a75d. Read the comment docs.

@dongsam dongsam merged commit 007913d into tendermint:develop Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant