Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting cosmos-sdk from v0.42.6 to v0.43.0 #433

Merged
merged 13 commits into from
Aug 26, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Aug 18, 2021

Description

closes: #432


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #433 (8375330) into develop (150acef) will decrease coverage by 0.04%.
The diff coverage is 97.10%.

❗ Current head 8375330 differs from pull request most recent head 2035741. Consider uploading reports for the commit 2035741 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #433      +/-   ##
===========================================
- Coverage    85.13%   85.08%   -0.05%     
===========================================
  Files           20       23       +3     
  Lines         2596     2615      +19     
===========================================
+ Hits          2210     2225      +15     
- Misses         223      226       +3     
- Partials       163      164       +1     
Impacted Files Coverage Δ
x/liquidity/keeper/migration.go 50.00% <50.00%> (ø)
x/liquidity/keeper/keeper.go 90.90% <100.00%> (ø)
x/liquidity/keeper/liquidity_pool.go 83.65% <100.00%> (-0.38%) ⬇️
x/liquidity/keeper/store.go 90.55% <100.00%> (ø)
x/liquidity/legacy/v043/helpers.go 100.00% <100.00%> (ø)
x/liquidity/legacy/v043/store.go 100.00% <100.00%> (ø)
x/liquidity/simulation/decoder.go 100.00% <100.00%> (ø)
x/liquidity/simulation/operations.go 79.74% <100.00%> (ø)
x/liquidity/types/keys.go 100.00% <100.00%> (ø)
x/liquidity/types/liquidity_pool.go 97.89% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 150acef...2035741. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review August 19, 2021 06:57
app/test_helpers.go Outdated Show resolved Hide resolved
x/liquidity/legacy/v043/helpers.go Outdated Show resolved Hide resolved
app/test_helpers.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V1: Porting to based sdk v0.43.0 and v0.44.0 for vega upgrade
3 participants