Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump cosmos-sdk to v0.44.3 #461

Merged
merged 3 commits into from Nov 11, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Oct 27, 2021

Description

closes: #460


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #461 (7049f47) into develop (e0def69) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #461   +/-   ##
========================================
  Coverage    85.49%   85.49%           
========================================
  Files           23       23           
  Lines         2634     2634           
========================================
  Hits          2252     2252           
  Misses         221      221           
  Partials       161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0def69...7049f47. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review October 27, 2021 07:25
Copy link
Contributor

@hallazzang hallazzang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam
Copy link
Contributor Author

dongsam commented Nov 3, 2021

We will hold the merge for a while until we are sure of Gaia v6 Vega's cosmos-sdk version.

@dongsam dongsam merged commit 2ccc2ec into tendermint:develop Nov 11, 2021
@dongsam dongsam mentioned this pull request Nov 11, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

build: bump cosmos-sdk version to v0.44.3
3 participants