This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Adapt abci protobuf files to ABCI++ spec (and vice versa) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergio-mena
requested review from
ebuchman,
josef-widder,
konnov and
milosevic
as code owners
|
Pushing a further commit removing the parts related to vote extensions. When the time comes, it will be easy to bring them back by reverting this commit Re-ran "make proto-gen" on the modified ".proto" file |
Thanks for the review! |
sergio-mena
commented
Feb 1, 2022
cmwaters
reviewed
Feb 1, 2022
cmwaters
approved these changes
Feb 1, 2022
creachadair
approved these changes
Feb 1, 2022
#394) * p2p/message: Changed evidence message to contain evidence, not a list of evidence * Update spec/p2p/messages/evidence.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v2.8.0...v2.9.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io>
thanethomson
reviewed
Feb 3, 2022
* PBTS: brief context and proposal added to README * PBTS: summary of algorithmic solution added to README * PBTS: Context section of README improved * PBTS: fixing links and page titles * PBTS: moved first drafts to v1/, links updated * PBTS: added issues to README, link to arXiv PDF * PBTS: brief context and proposal added to README * PBTS: summary of algorithmic solution added to README * PBTS: Context section of README improved * PBTS: fixing links and page titles * PBTS: moved first drafts to v1/, links updated * PBTS: added issues to README, link to arXiv PDF * Apply suggestions from code review Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> * Fixing linting problems Co-authored-by: Daniel Cason <cason@gandria> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com>
* abci++ proto updates * add finalizeblock * add deprecated fields
sergio-mena
force-pushed
the
sergio/386-abic++-protobufs
branch
from
5e529b9
to
a332279
Compare
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR the "methods" section of ABCI++ are in sync with the types in proto/tendermint/abci/
This is addressing issue #386
I am seeking to merge to sergio/abci++ (newly created branch) as merging with master would break anyone running "make proto-gen" from Tendermint Go repo.
In order to test the changes, I've adapted "scripts/protocgen.sh" so that "make proto-gen" picks up my PR branch.