Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fire NewBlock event after saving in case app process crashes #177

Closed
jaekwon opened this issue Jan 9, 2016 · 4 comments
Closed

Fire NewBlock event after saving in case app process crashes #177

jaekwon opened this issue Jan 9, 2016 · 4 comments
Labels
C:consensus Component: Consensus C:rpc Component: JSON RPC, gRPC T:bug Type Bug (Confirmed)
Milestone
post-launch

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Jan 9, 2016 •
edited by adrianbrink

For when the app crashes while committing a block, make sure NewBlock event doesn't get fired twice while we wait for the app to come back.

We will have to do more work to be able to exec txs from the last place that the app failed, to ensure that we don't end up with duplicate events. Shouldn't be too hard, we just need to be able to reset the app state to the latest hash, and then replay the same txs while ignoring events.
@ebuchman
Copy link
Contributor

ebuchman commented Jan 9, 2016

If we use an event cache, and don't flush it until the block completes, then we shouldnt have to worry about duplicate events from txs

@ebuchman ebuchman added the T:bug Type Bug (Confirmed) label Jul 5, 2016
@ebuchman ebuchman mentioned this issue Sep 12, 2016
Closed
@silasdavis silasdavis mentioned this issue Sep 12, 2016
Closed
@ebuchman ebuchman mentioned this issue Apr 14, 2017
Closed
15 tasks
@adrianbrink
Copy link
Contributor

@ebuchman Has this been dealt with in the referenced issues?

@ebuchman
Copy link
Contributor

ebuchman commented May 8, 2017

This is something we should review. I think there's a case where the event fires twice.

ebuchman added a commit that referenced this issue Jun 20, 2018
@ebuchman
Merge pull request #177 from tendermint/jenkins
bb68d7e 
tests: slow is smooth, smooth is fast
@xla xla added this to the post-launch milestone Aug 2, 2018
@xla xla added C:rpc Component: JSON RPC, gRPC C:consensus Component: Consensus labels Aug 2, 2018
@jackzampolin
Copy link
Contributor

Is this still an issue? Going to preemptively close. Please reopen if issue persists.

faddat pushed a commit to faddat/tendermint that referenced this issue Nov 23, 2022
@dependabot
build(deps): bump codecov/codecov-action from 2.0.1 to 2.0.2 (tenderm…
4008652 
…int#177)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
troian pushed a commit to akash-network/tendermint that referenced this issue Mar 11, 2023
@mergify @jmalicevic
tools: remove tm-signer-harness (backport tendermint#177) (tendermint…
0cb4b37 
…#183)

* tools: remove tm-signer-harness (tendermint#177)

* tools: remove tm-signer-harness

* Added changelog entry for tm-signer-harness folder removal

(cherry picked from commit 1587e95)

# Conflicts:
#	tools/tm-signer-harness/Makefile
#	tools/tm-signer-harness/README.md
#	tools/tm-signer-harness/internal/test_harness.go
#	tools/tm-signer-harness/internal/test_harness_test.go
#	tools/tm-signer-harness/main.go

* delete tm harness

Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
patiee pushed a commit to graphprotocol/tendermint that referenced this issue Aug 7, 2023
@mergify @jmalicevic
tools: remove tm-signer-harness (backport tendermint#177) (tendermint…
13c1ef3 
…#182)

* tools: remove tm-signer-harness (tendermint#177)

* tools: remove tm-signer-harness

* Added changelog entry for tm-signer-harness folder removal

(cherry picked from commit 1587e95)

# Conflicts:
#	tools/tm-signer-harness/Makefile
#	tools/tm-signer-harness/README.md
#	tools/tm-signer-harness/internal/test_harness.go
#	tools/tm-signer-harness/internal/test_harness_test.go
#	tools/tm-signer-harness/main.go

* removed tm signer harness

Co-authored-by: Jasmina Malicevic <jasmina.dustinac@gmail.com>
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this issue Nov 24, 2023
@jmalicevic
tools: remove tm-signer-harness (tendermint#177)
1587e95 
* tools: remove tm-signer-harness

* Added changelog entry for tm-signer-harness folder removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:consensus Component: Consensus C:rpc Component: JSON RPC, gRPC T:bug Type Bug (Confirmed)
Projects
None yet
Milestone
post-launch
Development

Successfully merging a pull request may close this issue.

Fire NewBlock event after BlockStore save silasdavis/tendermint
5 participants
@xla @jaekwon @ebuchman @jackzampolin @adrianbrink