Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unresponsive to signal interupts while sleeping for genesis time #2434

Closed
ebuchman opened this issue Sep 19, 2018 · 2 comments
Closed

Unresponsive to signal interupts while sleeping for genesis time #2434

ebuchman opened this issue Sep 19, 2018 · 2 comments
Assignees
@melekes
Labels
good first issue Contributions Welcome!! T:bug Type Bug (Confirmed)
Projects
Launch
Milestone
Wishlist

Comments

@ebuchman
Copy link
Contributor

As of #2389 we sleep until the genesis time is reached, but we don't set up our signal catching until we start the node, so we don't respond to CTRL-C while sleeping. We should probably use a select statement over a ticker and signal channel instead of the sleep.
@ebuchman ebuchman added the T:bug Type Bug (Confirmed) label Sep 19, 2018
@ebuchman ebuchman mentioned this issue Sep 19, 2018
Merged
4 tasks
@ValarDragon ValarDragon added this to the v1.0 milestone Sep 19, 2018
@xla
Copy link
Contributor

xla commented Sep 19, 2018

Alternatively can't we setup our signal trapping earlier?

@ebuchman ebuchman added help wanted good first issue Contributions Welcome!! and removed help wanted labels Sep 21, 2018
@melekes melekes self-assigned this Sep 24, 2018
melekes added a commit that referenced this issue Sep 24, 2018
@melekes
stop node upon receiving SIGTERM or CTRL-C
caaddb5 
even during genesis sleep by setting up interrupt before starting a node

Refs #2434
@melekes melekes mentioned this issue Sep 24, 2018
Merged
4 tasks
@xla xla added this to Queued in Launch via automation Sep 25, 2018
@xla xla moved this from Queued to Ongoing in Launch Sep 25, 2018
xla pushed a commit that referenced this issue Sep 25, 2018
@melekes @xla
node: Respond always to OS interrupts (#2479)
d12e55c 
* stop node upon receiving SIGTERM or CTRL-Ceven during genesis sleep by setting up interrupt before starting a node

Closes #2434

* call Start, not OnStart when starting a component to avoid:

```
E[09-24|10:13:15.805] Not stopping PubSub -- have not been started yet module=pubsub impl=PubSub
```

being printed on exit
@melekes
Copy link
Contributor

melekes commented Sep 28, 2018

Merged to develop.

@melekes melekes closed this as completed Sep 28, 2018
Launch automation moved this from Ongoing to Done Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
good first issue Contributions Welcome!! T:bug Type Bug (Confirmed)
Projects
No open projects
Launch
  
Done
Milestone
Wishlist
Development

No branches or pull requests
4 participants
@xla @melekes @ebuchman @ValarDragon