Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay starting node until Genesis time #2389

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Delay starting node until Genesis time #2389

merged 3 commits into from
Sep 18, 2018

Conversation

milosevic
Copy link
Contributor

@milosevic milosevic commented Sep 13, 2018 •
edited by melekes

Refs #2294

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

melekes
melekes reviewed Sep 13, 2018
View reviewed changes
node/node.go Outdated
now := tmtime.Now()
genTime := n.genesisDoc.GenesisTime
if genTime.After(now) {
time.Sleep(genTime.Sub(now))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should print a message like "Genesis time is in the future. Sleeping until then..."

ValarDragon
ValarDragon reviewed Sep 13, 2018
View reviewed changes
node/node_test.go

// create & start node
n, err := DefaultNewNode(config, log.TestingLogger())
n.GenesisDoc().GenesisTime = now.Add(5 * time.Second)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this reliably pass for smaller values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It pass for 10 millisecond.

@melekes melekes merged commit 2fbf810 into develop Sep 18, 2018
@melekes melekes deleted the zarko/2294-wait-until-genesis-time branch September 18, 2018 09:16
@ebuchman ebuchman mentioned this pull request Sep 19, 2018
Closed
@ebuchman
Copy link
Contributor

With this sleep we can't kill the program with SIGINT - see #2434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon left review comments

@melekes melekes melekes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@milosevic @ebuchman @melekes @ValarDragon