mempool: ErrPreCheck and more log info #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
approved these changes
Oct 29, 2018
mempool/mempool.go
Outdated
| @@ -66,6 +66,9 @@ var ( | |||
|
|
|||
| // ErrMempoolIsFull means Tendermint & an application can't handle that much load | |||
| ErrMempoolIsFull = errors.New("Mempool is full") | |||
|
|
|||
| // ErrPreCheck means the tx bytes are invalid - ie. too big. | |||
| ErrPreCheck = errors.New("Tx failed precheck") | |||
There was a problem hiding this comment.
Should we be explicit about the reason in the msg / logs? Otherwise devs will have to dig into the code in order to figure out what precheck is.
There was a problem hiding this comment.
Yeh that would be nice - maybe those funcs should return errors instead of bool?
|
|
I will fix. |
also, continue execution when checking txs in mempool_test if err=PreCheckErr
Codecov Report
@@ Coverage Diff @@
## develop #2724 +/- ##
===========================================
- Coverage 61.72% 61.58% -0.14%
===========================================
Files 207 207
Lines 16942 16951 +9
===========================================
- Hits 10458 10440 -18
- Misses 5622 5644 +22
- Partials 862 867 +5
|
ebuchman
commented
Nov 6, 2018
| if mem.postCheck == nil { | ||
| return true | ||
| } | ||
| if err := mem.postCheck(tx, r); err != nil { |
There was a problem hiding this comment.
I think we probably want to report this through the logger. Looks like right now we just swallow it, so it won't be obvious why a tx failed
| @@ -66,7 +65,10 @@ func checkTxs(t *testing.T, mempool *Mempool, count int) types.Txs { | |||
| t.Error(err) | |||
| } | |||
| if err := mempool.CheckTx(txBytes, nil); err != nil { | |||
| t.Fatalf("Error after CheckTx: %v", err) | |||
| if IsPreCheckError(err) { | |||
There was a problem hiding this comment.
why are these happening here?
There was a problem hiding this comment.
TestMempoolFilters will fail otherwise (it asserts a number of txs created, not panic)
| nopPreFilter := func(tx types.Tx) bool { return true } | ||
| nopPostFilter := func(tx types.Tx, res *abci.ResponseCheckTx) bool { return true } | ||
|
|
||
| // This is the same filter we expect to be used within node/node.go and state/execution.go |
ebuchman
pushed a commit
that referenced
this pull request
Nov 7, 2018
maxim-levy
pushed a commit
to maxim-levy/tendermint
that referenced
this pull request
Nov 13, 2018
* 'master' of https://github.com/tendermint/tendermint: (330 commits) Release/v0.26.1 (tendermint#2803) fix amino overhead computation for Tx (tendermint#2792) p2p: re-check after sleeps (tendermint#2664) check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787) p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797) test AutoFile#Size (happy path) [autofile/group] do not panic when checking size openFile creates a file if not exist => ErrNotExist is not possible use our logger in autofile/group Add tests for ValidateBasic methods (tendermint#2754) [docs] improve organization of ABCI docs & fix links (tendermint#2749) p2p: peer-id -> peer_id (tendermint#2771) mempool: print postCheck error (tendermint#2762) Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756) Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758) mempool: ErrPreCheck and more log info (tendermint#2724) Release/v0.26.0 (tendermint#2726) [ADR] [DRAFT] pubsub 2.0 (tendermint#2532) validate reactor messages (tendermint#2711) TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't returning error when failing PreCheck before.