[ADR] [DRAFT] pubsub 2.0 #2532
Merged
[ADR] [DRAFT] pubsub 2.0 #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebuchman
reviewed
Oct 3, 2018
melekes
force-pushed
the
anton/pubsub-adr
branch
from
aec4f63
to
056d335
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2532 +/- ##
===========================================
- Coverage 62.31% 62.26% -0.05%
===========================================
Files 212 212
Lines 17099 17185 +86
===========================================
+ Hits 10655 10701 +46
- Misses 5547 5587 +40
Partials 897 897
|
melekes
force-pushed
the
anton/pubsub-adr
branch
from
ef017f0
to
ac4743e
Compare
liamsi
reviewed
Nov 1, 2018
docs/architecture/adr-033-pubsub.md
Outdated
|
|
||
| Go channels are de-facto standard for carrying data between goroutines. | ||
|
|
||
| **Question: Does it worth switching to callback functions?** |
There was a problem hiding this comment.
This should be: “Is it worth ...”
docs/architecture/adr-033-pubsub.md
Outdated
|
|
||
| ### Channels vs Callbacks | ||
|
|
||
| Yet another question is whenever we should use channels for message transmission or |
There was a problem hiding this comment.
... “question is whether we should” ... (?) or “in which cases we should...”
melekes
force-pushed
the
anton/pubsub-adr
branch
from
19cd4c0
to
18c5f82
Compare
liamsi
approved these changes
Nov 1, 2018
| ### Positive | ||
|
|
||
| - more idiomatic interface | ||
| - subscribers know what tags msg was published with |
There was a problem hiding this comment.
nit: this could be made a whole sentence; e.g., something along the lines "adds the ability to subscribers to know with which associated tags a messages was published with"
maxim-levy
pushed a commit
to maxim-levy/tendermint
that referenced
this pull request
Nov 13, 2018
* 'master' of https://github.com/tendermint/tendermint: (330 commits) Release/v0.26.1 (tendermint#2803) fix amino overhead computation for Tx (tendermint#2792) p2p: re-check after sleeps (tendermint#2664) check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787) p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797) test AutoFile#Size (happy path) [autofile/group] do not panic when checking size openFile creates a file if not exist => ErrNotExist is not possible use our logger in autofile/group Add tests for ValidateBasic methods (tendermint#2754) [docs] improve organization of ABCI docs & fix links (tendermint#2749) p2p: peer-id -> peer_id (tendermint#2771) mempool: print postCheck error (tendermint#2762) Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756) Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758) mempool: ErrPreCheck and more log info (tendermint#2724) Release/v0.26.0 (tendermint#2726) [ADR] [DRAFT] pubsub 2.0 (tendermint#2532) validate reactor messages (tendermint#2711) TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #951, #1879, #1880