TMHASH is 32 bytes. Closes #1990 #2732
Conversation
|
|
||
| // Sum returns the SHA256 of the bz. | ||
| func Sum(bz []byte) []byte { | ||
| h := sha256.Sum256(bz) |
There was a problem hiding this comment.
Nit: We can probably just return sha256.Sum(bz) here.
There was a problem hiding this comment.
Can't because it's a [32]byte and not []byte
There was a problem hiding this comment.
Oh, I thought sha256 implements the hash.Hash interface which returns []byte. It actually does but not via the "static" methods, only via sha256.New().Sum(bz). Not important though!
There was a problem hiding this comment.
Could just do sha256.Sum(bz)[:], no?
There was a problem hiding this comment.
No, theres a weird reason why that doesn't work, I'm forgetting what it was.
| const ( | ||
| TruncatedSize = 20 | ||
| ) | ||
|
|
||
| type sha256trunc struct { |
There was a problem hiding this comment.
I think this should be called AddressHash
There was a problem hiding this comment.
LGTM. The constants e.g.MaxHeaderBytes etc need to be updated to fix the tests though (TestMaxHeaderBytes, TestMaxEvidenceBytes, TestMaxVoteBytes).
TestBlockMakePartSetWithEvidence seems to fail because the now marshalled data exceeds 2 "partSize" chunks (?) 🤔
Codecov Report
@@ Coverage Diff @@
## develop #2732 +/- ##
==========================================
Coverage ? 62.28%
==========================================
Files ? 212
Lines ? 17063
Branches ? 0
==========================================
Hits ? 10628
Misses ? 5563
Partials ? 872
|
* 'master' of https://github.com/tendermint/tendermint: (330 commits) Release/v0.26.1 (tendermint#2803) fix amino overhead computation for Tx (tendermint#2792) p2p: re-check after sleeps (tendermint#2664) check the result of `ps.peer.Send` before calling `ps.setHasVote` (tendermint#2787) p2p: AddressBook requires addresses to have IDs; Do not close conn immediately after sending pex addrs in seed mode (tendermint#2797) test AutoFile#Size (happy path) [autofile/group] do not panic when checking size openFile creates a file if not exist => ErrNotExist is not possible use our logger in autofile/group Add tests for ValidateBasic methods (tendermint#2754) [docs] improve organization of ABCI docs & fix links (tendermint#2749) p2p: peer-id -> peer_id (tendermint#2771) mempool: print postCheck error (tendermint#2762) Fix crypto/merkle ProofOperators.Verify to check bounds on keypath pa… (tendermint#2756) Mempool WAL is still created by default in home directory, leads to permission errors (tendermint#2758) mempool: ErrPreCheck and more log info (tendermint#2724) Release/v0.26.0 (tendermint#2726) [ADR] [DRAFT] pubsub 2.0 (tendermint#2532) validate reactor messages (tendermint#2711) TMHASH is 32 bytes. Closes tendermint#1990 (tendermint#2732) ...
Closes #1990
Change TMHASH to 32-bytes.
Include TMHASHTruncated as TMHASH[:20]
Add
crypto.AddressSize = TMHASHTruncated.Size