New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p2p: fix logging peer address #2773
Labels
Milestone
Comments
u5surf
added a commit
to u5surf/tendermint
that referenced
this issue
Nov 8, 2018
u5surf
added a commit
to u5surf/tendermint
that referenced
this issue
Nov 8, 2018
Committer: u5surf <u5.horie@gmail.com>
u5surf
added a commit
to u5surf/tendermint
that referenced
this issue
Nov 8, 2018
Committer: u5surf <u5.horie@gmail.com>
u5surf
pushed a commit
to u5surf/tendermint
that referenced
this issue
Nov 8, 2018
u5surf
added a commit
to u5surf/tendermint
that referenced
this issue
Nov 8, 2018
u5surf
added a commit
to u5surf/tendermint
that referenced
this issue
Nov 8, 2018
Fixed in #2797 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Pointed out in #2721 (comment)
It's because we're passing a function pointer rather than calling the function in:
tendermint/p2p/switch.go
Line 619 in 6e9aee5
We should just pass the NetAddress() there, no need to call String().
But note even if we do that, we still lose the ID. That's because in
tendermint/p2p/netaddress.go
Lines 316 to 321 in 6e9aee5
@
, eg.76e35576b8dd1cf8049fea382fda8ac621a9c6ee@tcp://0.0.0.0:26656
. So we need fix this tooThe text was updated successfully, but these errors were encountered: