Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: remove key suffixes #4941

Merged
merged 6 commits into from
Jun 3, 2020
Merged

crypto: remove key suffixes #4941

merged 6 commits into from
Jun 3, 2020

Conversation

tac0turtle
Copy link
Contributor

Description

  • remove keyname suffix from keys

Closes: #2228

- remove keyname suffix from keys
@tac0turtle tac0turtle added C:crypto Component: Crypto S:automerge Automatically merge PR when requirements pass labels Jun 2, 2020
@tac0turtle tac0turtle self-assigned this Jun 2, 2020
@auto-comment
Copy link

auto-comment bot commented Jun 2, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle marked this pull request as ready for review June 2, 2020 15:53
@tac0turtle tac0turtle changed the title keys: remove suffixes (#4633) crypto: remove key suffixes (#4633) Jun 2, 2020
@tac0turtle tac0turtle changed the title crypto: remove key suffixes (#4633) crypto: remove key suffixes Jun 2, 2020
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #4941 into master will decrease coverage by 0.15%.
The diff coverage is 65.15%.

@@            Coverage Diff             @@
##           master    #4941      +/-   ##
==========================================
- Coverage   62.83%   62.68%   -0.16%     
==========================================
  Files         197      197              
  Lines       20051    20053       +2     
==========================================
- Hits        12599    12570      -29     
- Misses       6427     6455      +28     
- Partials     1025     1028       +3     
Impacted Files Coverage Δ
tools/tm-signer-harness/internal/test_harness.go 61.40% <ø> (ø)
crypto/sr25519/pubkey.go 39.28% <14.28%> (ø)
crypto/ed25519/ed25519.go 50.00% <45.45%> (ø)
crypto/sr25519/privkey.go 47.61% <50.00%> (ø)
abci/example/kvstore/persistent_kvstore.go 51.96% <100.00%> (ø)
crypto/encoding/amino/amino.go 100.00% <100.00%> (ø)
crypto/multisig/codec.go 100.00% <100.00%> (ø)
crypto/multisig/threshold_pubkey.go 61.90% <100.00%> (ø)
crypto/sr25519/codec.go 100.00% <100.00%> (ø)
p2p/conn/secret_connection.go 73.50% <100.00%> (ø)
... and 11 more

@tac0turtle tac0turtle added the T:breaking Type: Breaking Change label Jun 2, 2020
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit 99d88cb into master Jun 3, 2020
@mergify mergify bot deleted the key_suffixes branch June 3, 2020 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:crypto Component: Crypto S:automerge Automatically merge PR when requirements pass T:breaking Type: Breaking Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crypto: drop redundant suffixes like ed25519.PubKeyEd25519
2 participants