Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tendermint Application Guide for Java and Kotlin out of date. Location of proto files no longer valid #5034

Closed
jonpoulter opened this issue Jun 19, 2020 · 1 comment · Fixed by #5123
Closed

Tendermint Application Guide for Java and Kotlin out of date. Location of proto files no longer valid #5034

jonpoulter opened this issue Jun 19, 2020 · 1 comment · Fixed by #5123
Labels
C:docs Component: Documentation
Projects
Docs
Milestone
v0.34 follow-up

Comments

@jonpoulter
Copy link

jonpoulter commented Jun 19, 2020 •
edited

https://docs.tendermint.com/master/guides/java.html

The head of the git repo does not reflect the location of the proto files as stated in the following step

mkdir -p
$KVSTORE_HOME/src/main/proto/github.com/tendermint/tendermint/abci/types
$KVSTORE_HOME/src/main/proto/github.com/tendermint/tendermint/crypto/merkle
$KVSTORE_HOME/src/main/proto/github.com/tendermint/tendermint/libs/kv
$KVSTORE_HOME/src/main/proto/github.com/gogo/protobuf/gogoproto

cp $GOPATH/src/github.com/tendermint/tendermint/abci/types/types.proto
$KVSTORE_HOME/src/main/proto/github.com/tendermint/tendermint/abci/types/types.proto
cp $GOPATH/src/github.com/tendermint/tendermint/crypto/merkle/merkle.proto
$KVSTORE_HOME/src/main/proto/github.com/tendermint/tendermint/crypto/merkle/merkle.proto
cp $GOPATH/src/github.com/tendermint/tendermint/libs/kv/types.proto
$KVSTORE_HOME/src/main/proto/github.com/tendermint/tendermint/libs/kv/types.proto
cp $GOPATH/src/github.com/gogo/protobuf/gogoproto/gogo.proto
$KVSTORE_HOME/src/main/proto/github.com/gogo/protobuf/gogoproto/gogo.proto
@tac0turtle tac0turtle added the C:docs Component: Documentation label Jun 19, 2020
@tac0turtle
Copy link
Contributor

thank you for creating the issue. Would you like to open a PR? otherwise I will take a look at this in the coming days.

@tac0turtle tac0turtle added this to To do in Docs Jun 29, 2020
@melekes melekes added this to the v0.34 follow-up milestone Jul 3, 2020
@tac0turtle tac0turtle mentioned this issue Jul 15, 2020
Merged
@mergify mergify bot closed this as completed in #5123 Jul 15, 2020
Docs automation moved this from To do to Done Jul 15, 2020
mergify bot pushed a commit that referenced this issue Jul 15, 2020
@tac0turtle
docs: modify needed proto files for guides (#5123)
9695690 
## Description

This pr modifies the needed proto files for the java and kotlin guides. 

Closes: #5034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:docs Component: Documentation
Projects
No open projects
Docs
  
Done
Milestone
v0.34 follow-up
Development

Successfully merging a pull request may close this issue.

docs: modify needed proto files for guides tendermint/tendermint
3 participants
@melekes @jonpoulter @tac0turtle