Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: modify needed proto files for guides #5123

Merged
merged 2 commits into from Jul 15, 2020
Merged

docs: modify needed proto files for guides #5123

merged 2 commits into from Jul 15, 2020

Conversation

tac0turtle
Copy link
Contributor

Description

This pr modifies the needed proto files for the java and kotlin guides.

Closes: #5034

@tac0turtle tac0turtle added the C:docs Component: Documentation label Jul 15, 2020
@tac0turtle tac0turtle self-assigned this Jul 15, 2020
@auto-comment
Copy link

auto-comment bot commented Jul 15, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@tac0turtle tac0turtle marked this pull request as ready for review July 15, 2020 08:15
@tac0turtle tac0turtle added the S:automerge Automatically merge PR when requirements pass label Jul 15, 2020
@mergify mergify bot merged commit 9695690 into master Jul 15, 2020
@mergify mergify bot deleted the marko/5034_proto_guides branch July 15, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes approved these changes

@tessr tessr Awaiting requested review from tessr

Assignees

@tac0turtle tac0turtle

Labels
C:docs Component: Documentation S:automerge Automatically merge PR when requirements pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tendermint Application Guide for Java and Kotlin out of date. Location of proto files no longer valid
2 participants
@tac0turtle @melekes