server: WriteRPCResponseArrayHTTP is untested and could be folded into a variadic variant of WriteRPCResponseHTTP

[odeke-em]

Am coming here via an audit of cosmos-sdk. The code for WriteRPCResponseArrayHTTP seems untested but also adds surface area, and duplicates a bunch of code unnecessarily, if kept perhaps could use an improved name like WriteRPCResponsesHTTP, as array is fallacious here (sorry for the nit picking)

tendermint/rpc/jsonrpc/server/http_server.go

Lines 109 to 119 in 5223cba

	func WriteRPCResponseHTTP(w http.ResponseWriter, res types.RPCResponse) {
	jsonBytes, err := json.MarshalIndent(res, "", " ")
	if err != nil {
	panic(err)
	}
	w.Header().Set("Content-Type", "application/json")
	w.WriteHeader(200)
	if _, err := w.Write(jsonBytes); err != nil {
	panic(err)
	}
	}

tendermint/rpc/jsonrpc/server/http_server.go

Lines 124 to 139 in 5223cba

	func WriteRPCResponseArrayHTTP(w http.ResponseWriter, res []types.RPCResponse) {
	if len(res) == 1 {
	WriteRPCResponseHTTP(w, res[0])
	} else {
	jsonBytes, err := json.MarshalIndent(res, "", " ")
	if err != nil {
	panic(err)
	}
	w.Header().Set("Content-Type", "application/json")
	w.WriteHeader(200)
	if _, err := w.Write(jsonBytes); err != nil {
	panic(err)
	}
	}
	}

but could really be folded into a variadic version of WriteRPCResponseHTTP whereby if len(res) == 1, proceed normal, lest JSON indent.

func WriteRPCResponseHTTP(w http.ResponseWriter, res ...types.RPCResponse) {
        var toMarshal interface{} = res
	if len(res) == 1 {
	        toMarshal = res[0]
        }
	jsonBytes, err := json.MarshalIndent(toMarshal, "", "  ")
	if err != nil {
		http.Error(w, err.Error(), http.StatusBadRequest)
                return
	}
	w.Header().Set("Content-Type", "application/json")
	if _, err := w.Write(jsonBytes); err != nil {
		panic(err)
	}
}

If the serve returns without error, a 200 is implicit.