Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc/jsonrpc/server: merge WriteRPCResponseHTTP and WriteRPCResponseAr #5141

Merged
merged 5 commits into from Jul 21, 2020

Conversation

melekes
Copy link
Contributor

@melekes melekes commented Jul 21, 2020

...rrayHTTP

Closes #5135

Also, wrote a test for WriteRPCResponseHTTPError and used it with correct status codes according to https://www.jsonrpc.org/historical/json-rpc-over-http.html#response-codes

@melekes melekes requested a review from tessr as a code owner July 21, 2020 12:05
@auto-comment
Copy link

auto-comment bot commented Jul 21, 2020

👋 Thanks for creating a PR!

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer
  • Applied Appropriate Labels

Thank you for your contribution to Tendermint! 🚀

@melekes melekes self-assigned this Jul 21, 2020
@melekes melekes added R:minor Release: Minor S:automerge Automatically merge PR when requirements pass and removed R:minor Release: Minor labels Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #5141 into master will increase coverage by 0.02%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master    #5141      +/-   ##
==========================================
+ Coverage   62.61%   62.63%   +0.02%     
==========================================
  Files         256      256              
  Lines       27161    27172      +11     
==========================================
+ Hits        17007    17020      +13     
- Misses       8658     8664       +6     
+ Partials     1496     1488       -8     
Impacted Files Coverage Δ
rpc/jsonrpc/server/http_uri_handler.go 39.82% <0.00%> (-1.09%) ⬇️
rpc/jsonrpc/server/http_json_handler.go 63.38% <60.00%> (-0.20%) ⬇️
rpc/jsonrpc/server/http_server.go 59.82% <100.00%> (+4.73%) ⬆️
consensus/reactor.go 75.81% <0.00%> (-2.91%) ⬇️
consensus/state.go 72.05% <0.00%> (-0.83%) ⬇️
statesync/messages.go 86.20% <0.00%> (-0.75%) ⬇️
blockchain/v0/pool.go 79.29% <0.00%> (-0.32%) ⬇️
blockchain/v2/reactor.go 35.92% <0.00%> (+1.48%) ⬆️
types/tx.go 93.10% <0.00%> (+3.44%) ⬆️
... and 4 more

Copy link
Contributor

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. pending linting fixes

@mergify mergify bot merged commit 95fc7e5 into master Jul 21, 2020
@mergify mergify bot deleted the anton/5135-WriteRPCResponseHTTP branch July 21, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:automerge Automatically merge PR when requirements pass
Projects
None yet
2 participants