Deprecate/refactor content in docs/specification #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zramsay
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1934 +/- ##
========================================
Coverage 60.72% 60.72%
========================================
Files 217 217
Lines 16976 16976
========================================
Hits 10308 10308
- Misses 5778 5779 +1
+ Partials 890 889 -1
|
melekes
reviewed
Jul 11, 2018
| 5. After editing, convert this file back into binary form by running: | ||
|
|
||
| ``` | ||
| ./scripts/json2wal/json2wal /tmp/corrupted_wal > "$TMHOME/data/cs.wal/wal" |
There was a problem hiding this comment.
this tool was removed. we need to find and bring it back
There was a problem hiding this comment.
@melekes Can you create a follow-up issue?
| @@ -1,172 +0,0 @@ | |||
| Wire Protocol | |||
There was a problem hiding this comment.
shouldn't we at least provide a link to go-amino?
There was a problem hiding this comment.
There was a problem hiding this comment.
the docs landing page will need improvements after this PR, which will point people to various places
xla
approved these changes
Jul 11, 2018
🍡| 5. After editing, convert this file back into binary form by running: | ||
|
|
||
| ``` | ||
| ./scripts/json2wal/json2wal /tmp/corrupted_wal > "$TMHOME/data/cs.wal/wal" |
There was a problem hiding this comment.
@melekes Can you create a follow-up issue?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1814
replaces #1914