Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reduce log output in test_cover #2105

Merged
merged 1 commit into from
Jul 29, 2018
Merged

ci: Reduce log output in test_cover #2105

merged 1 commit into from
Jul 29, 2018

Conversation

ValarDragon
Copy link
Contributor

This commit makes it such that circle CI only shows the module whose
tests it is currently running in the log, unless a test fails. For each
failing test, it will display the name of all failing tests, along with
their log output. This is done to make
our log output far more scrollable. We lose no information in debugging.

An example with go test:
I added t.Log("test name") and t.Fail() to the bottom of two tests, and then ran go test, the following log output appeared:

 go test
--- FAIL: TestErrorPanic (0.00s)
	errors_test.go:30: TESTERRORPANIC
--- FAIL: TestErrorNewErrorWithTrace (0.00s)
	errors_test.go:97: TestErrorNewErrorWithTrace

(This test code is not in the commit, its just meant to show how it works)
Take a look at the CI logs!

  • Updated all relevant documentation in docs - n/a
  • Updated all code comments where relevant - n/a
  • Wrote tests - n/a
  • Updated CHANGELOG.md - not user facing, only affects CI + reviewing PR's

This commit makes it such that circle CI only shows the module whose
tests it is currently running in the log, unless a test fails. For each
failing test, it will display the name of all failing tests, along with
their log output. This is done to make
our log output far more scrollable. We lose no information in debugging.
@codecov-io
Copy link

Codecov Report

Merging #2105 into develop will decrease coverage by 0.31%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #2105      +/-   ##
===========================================
- Coverage    62.73%   62.42%   -0.32%     
===========================================
  Files          215      215              
  Lines        17376    17369       -7     
===========================================
- Hits         10901    10842      -59     
- Misses        5586     5637      +51     
- Partials       889      890       +1
Impacted Files Coverage Δ
p2p/pex/errors.go 0% <0%> (-20%) ⬇️
p2p/node_info.go 45.61% <0%> (-5.27%) ⬇️
consensus/reactor.go 73.02% <0%> (-4.84%) ⬇️
proxy/client.go 22.22% <0%> (-3.59%) ⬇️
libs/common/os.go 16.9% <0%> (-3.1%) ⬇️
mempool/reactor.go 64.19% <0%> (-2.47%) ⬇️
p2p/peer.go 57.95% <0%> (-2.28%) ⬇️
evidence/reactor.go 65.93% <0%> (-2.2%) ⬇️
p2p/pex/pex_reactor.go 71.86% <0%> (-1.7%) ⬇️
p2p/listener.go 49.59% <0%> (-1.63%) ⬇️
... and 6 more

@xla xla changed the title CI: Reduce log output in test_cover ci: Reduce log output in test_cover Jul 29, 2018
@xla xla self-assigned this Jul 29, 2018
@xla xla added T:test Type: Tests that need love T:enhancement Type: Enhancement labels Jul 29, 2018
@xla xla added this to the launch milestone Jul 29, 2018
Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :octocat: :shipit: 🍡

@xla xla merged commit 231cdc1 into develop Jul 29, 2018
@xla xla deleted the dev/reduce_ci_logs branch July 29, 2018 23:05
firelizzard18 pushed a commit to AccumulateNetwork/tendermint that referenced this pull request Feb 1, 2024
close: tendermint#1613 

New structure for documentation using the [diataxis
framework](https://diataxis.fr). Created landing pages for the major
sections and re-organized the existing content into one of the 4 topics
of the diataxis framework (tutorials, how-to guides, technical reference
and explanation)


#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [X] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:enhancement Type: Enhancement T:test Type: Tests that need love
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants