Cleanup up Multisig naming #2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2255 +/- ##
===========================================
- Coverage 62.42% 60.64% -1.78%
===========================================
Files 215 196 -19
Lines 17664 16239 -1425
===========================================
- Hits 11026 9848 -1178
+ Misses 5726 5535 -191
+ Partials 912 856 -56
|
ValarDragon
reviewed
Aug 22, 2018
| @@ -10,15 +10,15 @@ import ( | |||
| // TODO: Figure out API for others to either add their own pubkey types, or | |||
| // to make verify / marshal accept a cdc. | |||
| const ( | |||
| ThresholdPubkeyAminoRoute = "tendermint/PubkeyMultisigThreshold" | |||
| PubKeyMultisigThresholdAminoRoute = "tendermint/PubKeyMultisigThreshold" | |||
There was a problem hiding this comment.
Should we omit the multisig from the varname since it's in the package? Also should we omit the pubkey from the var name since there's no privkey
There was a problem hiding this comment.
Mmmm .... I was hoping to reach parity between the var name and the Amino route. We can't remove Multisig from the amino route because there's no pkg information there, it needs to be the full tendermint/PubKeyMultisigThreshold.
We could consider removing Multisig from the var name, but I think we should keep PubKey for consistency/clarity
xla
approved these changes
Aug 22, 2018
🍡
crypto/multisig/multisignature.go
Outdated
| @@ -4,20 +4,21 @@ import ( | |||
| "errors" | |||
|
|
|||
| "github.com/tendermint/tendermint/crypto" | |||
| bA "github.com/tendermint/tendermint/crypto/multisig/bitarray" | |||
There was a problem hiding this comment.
This alias does more harm than good, obscuring what is imported here.
| @@ -10,15 +10,15 @@ import ( | |||
| // TODO: Figure out API for others to either add their own pubkey types, or | |||
| // to make verify / marshal accept a cdc. | |||
| const ( | |||
| ThresholdPubkeyAminoRoute = "tendermint/PubkeyMultisigThreshold" | |||
| PubKeyMultisigThresholdAminoRoute = "tendermint/PubKeyMultisigThreshold" | |||
ValarDragon
approved these changes
Aug 25, 2018
melekes
approved these changes
Aug 25, 2018
melekes
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up from #2163.
This PR standardizes the naming used in the multisig package and adds the multisig pubkey to the crypto/encoding/amino codec.
It also moves the compact bit array into it's own package.