-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup up Multisig naming #2255
Changes from 5 commits
37c10ae
888d62f
2225bad
1501e4e
34c7035
3a9342a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package multisig | ||
package bitarray | ||
|
||
import ( | ||
"bytes" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package multisig | ||
package bitarray | ||
|
||
import ( | ||
"encoding/json" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,15 +10,15 @@ import ( | |
// TODO: Figure out API for others to either add their own pubkey types, or | ||
// to make verify / marshal accept a cdc. | ||
const ( | ||
ThresholdPubkeyAminoRoute = "tendermint/PubkeyMultisigThreshold" | ||
PubKeyMultisigThresholdAminoRoute = "tendermint/PubKeyMultisigThreshold" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we omit the multisig from the varname since it's in the package? Also should we omit the pubkey from the var name since there's no privkey There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 to both. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mmmm .... I was hoping to reach parity between the var name and the Amino route. We can't remove We could consider removing |
||
) | ||
|
||
var cdc = amino.NewCodec() | ||
|
||
func init() { | ||
cdc.RegisterInterface((*crypto.PubKey)(nil), nil) | ||
cdc.RegisterConcrete(ThresholdMultiSignaturePubKey{}, | ||
ThresholdPubkeyAminoRoute, nil) | ||
cdc.RegisterConcrete(PubKeyMultisigThreshold{}, | ||
PubKeyMultisigThresholdAminoRoute, nil) | ||
cdc.RegisterConcrete(ed25519.PubKeyEd25519{}, | ||
ed25519.PubKeyAminoRoute, nil) | ||
cdc.RegisterConcrete(secp256k1.PubKeySecp256k1{}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This alias does more harm than good, obscuring what is imported here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!