Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abci: update install instructions for abci-cli #2301

Closed
wants to merge 1 commit into from
Closed

abci: update install instructions for abci-cli #2301

wants to merge 1 commit into from

Conversation

gosuri
Copy link

@gosuri gosuri commented Aug 30, 2018

  • [x ] Updated all relevant documentation in docs
  • [x ] Updated all code comments where relevant
  • [x ] Wrote tests
  • [x ] Updated CHANGELOG_PENDING.md

@melekes melekes changed the base branch from master to develop August 31, 2018 07:51
melekes
melekes reviewed Aug 31, 2018
View reviewed changes
abci/README.md
@@ -43,9 +43,9 @@ example apps. To install it:

```
go get github.com/tendermint/abci
cd $GOPATH/src/github.com/tendermint/abci
cd $GOPATH/src/github.com/tendermint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

mkdir -p $GOPATH/src/github.com/tendermint
cd $GOPATH/src/github.com/tendermint
git clone https://github.com/tendermint/tendermint.git
cd tendermint
make get_tools
make get_vendor_deps
make install_abci

abci/README.md
@@ -43,9 +43,9 @@ example apps. To install it:

```
go get github.com/tendermint/abci
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

@melekes
Copy link
Contributor

melekes commented Aug 31, 2018

also needs to be rebased against latest develop https://stackoverflow.com/questions/7244321/how-do-i-update-a-github-forked-repository#7244456

melekes added a commit that referenced this pull request Sep 4, 2018
@melekes
update outdated abci-cli install instructions
c3e260b 
#2301
@melekes
Copy link
Contributor

melekes commented Sep 4, 2018

Closed due to no response.

@melekes melekes closed this Sep 4, 2018
@melekes melekes mentioned this pull request Sep 4, 2018
Merged
melekes added a commit that referenced this pull request Sep 4, 2018
@melekes
update outdated abci-cli install instructions (#2325)
29d2db3 
#2301
NexZhu pushed a commit to daotl/go-acei that referenced this pull request Oct 27, 2021
@melekes
update outdated abci-cli install instructions (#2325)
fb1c33c 
tendermint/tendermint#2301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melekes melekes melekes left review comments

@ebuchman ebuchman Awaiting requested review from ebuchman

@xla xla Awaiting requested review from xla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gosuri @melekes