Validator set changes tests #344

melekes · 2016-12-23T16:11:54Z

This is failing right now, so please do not merge!

Sometimes this test is failing with: "Timed out waiting for all validators to commit a block" (timeout was increased by 10 seconds)

Log:

INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{1:4F6BE1A4BB35 11/00/2(Precommit) 75860B411898 /C78B5D6BAC4A.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:_X_XX} map[]}"
INFO[12-23|13:02:46] enterCommit(11/0). Current: 11/0/RoundStepPrecommit module=consensus
NOTE[12-23|13:02:46] Finalizing commit of block with 2 txs    module=consensus height=11 hash=75860B411898B6A27AA40C726DE119A070F40B5B root=65B64A51FF9F58D823C23CF034E24291FCEDD2BA
INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=5
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{1:4F6BE1A4BB35 11/00/2(Precommit) 75860B411898 /C78B5D6BAC4A.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:_X_XX} map[]}"
INFO[12-23|13:02:46] enterCommit(11/0). Current: 11/0/RoundStepPrecommit module=consensus
NOTE[12-23|13:02:46] Finalizing commit of block with 2 txs    module=consensus height=11 hash=75860B411898B6A27AA40C726DE119A070F40B5B root=65B64A51FF9F58D823C23CF034E24291FCEDD2BA
INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=6
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=3
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{3:C25E810EEBF0 11/00/2(Precommit) 75860B411898 /EA98401DCAF6.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:<nil> BA{5:__XXX} map[]}"
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{1:4F6BE1A4BB35 11/00/2(Precommit) 75860B411898 /C78B5D6BAC4A.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:_XXXX} map[]}"
INFO[12-23|13:02:46] enterCommit(11/0). Current: 11/0/RoundStepPrecommit module=consensus
NOTE[12-23|13:02:46] Finalizing commit of block with 2 txs    module=consensus height=11 hash=75860B411898B6A27AA40C726DE119A070F40B5B root=65B64A51FF9F58D823C23CF034E24291FCEDD2BA
INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=1
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{0:2E957CF919E5 11/00/2(Precommit) 75860B411898 /B1D715AFA354.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:<nil> BA{5:X_XXX} map[]}"
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{1:4F6BE1A4BB35 11/00/2(Precommit) 75860B411898 /C78B5D6BAC4A.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]}"
INFO[12-23|13:02:46] enterCommit(11/0). Current: 11/0/RoundStepPrecommit module=consensus
NOTE[12-23|13:02:46] Finalizing commit of block with 2 txs    module=consensus height=11 hash=75860B411898B6A27AA40C726DE119A070F40B5B root=65B64A51FF9F58D823C23CF034E24291FCEDD2BA
INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=2
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XX_XX} map[]} module=consensus
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]} module=consensus
NOTE[12-23|13:02:46] enterNewRound(12/0). Current: 12/0/RoundStepNewHeightmodule=consensus
INFO[12-23|13:02:46] enterPropose(12/0). Current: 12/0/RoundStepNewRound module=consensus
INFO[12-23|13:02:46] enterPropose: Not our turn to propose    module=consensus proposer=2E957CF919E5BAFFB9CFCABE470BFD85A03531F4 privValidator="PrivValidator{19D27C755AE07DE3851E6F8076E42C2E812BAEB7 LH:0, LR:0, LS:0}"
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XX_XX} map[]} module=consensus
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]} module=consensus
NOTE[12-23|13:02:46] enterNewRound(12/0). Current: 12/0/RoundStepNewHeightmodule=consensus
INFO[12-23|13:02:46] enterPropose(12/0). Current: 12/0/RoundStepNewRound module=consensus
INFO[12-23|13:02:46] enterPropose: Not our turn to propose    module=consensus proposer=2E957CF919E5BAFFB9CFCABE470BFD85A03531F4 privValidator="PrivValidator{E3461FF43B6634012FBFF95DF897BF0F16FF7AD1 LH:0, LR:0, LS:0}"
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{0:2E957CF919E5 11/00/2(Precommit) 75860B411898 /B1D715AFA354.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:<nil> BA{5:X_XXX} map[]}"
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{1:4F6BE1A4BB35 11/00/2(Precommit) 75860B411898 /C78B5D6BAC4A.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]}"
INFO[12-23|13:02:46] enterCommit(11/0). Current: 11/0/RoundStepPrecommit module=consensus
NOTE[12-23|13:02:46] Finalizing commit of block with 2 txs    module=consensus height=11 hash=75860B411898B6A27AA40C726DE119A070F40B5B root=65B64A51FF9F58D823C23CF034E24291FCEDD2BA
INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=7
INFO[12-23|13:02:46] Added to precommit                       module=consensus vote="Vote{1:4F6BE1A4BB35 11/00/2(Precommit) 75860B411898 /C78B5D6BAC4A.../}" precommits="VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]}"
INFO[12-23|13:02:46] enterCommit(11/0). Current: 11/0/RoundStepPrecommit module=consensus
NOTE[12-23|13:02:46] Finalizing commit of block with 2 txs    module=consensus height=11 hash=75860B411898B6A27AA40C726DE119A070F40B5B root=65B64A51FF9F58D823C23CF034E24291FCEDD2BA
INFO[12-23|13:02:46] Block{
  Header{
    ChainID:        tendermint_test
    Height:         11
    Time:           2016-12-23 13:02:46.052 +0000 UTC
    NumTxs:         2
    LastBlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    LastCommit:     83F202126FBA458507F7E200DCCEE7E62E4474DD
    Data:           36721760CD4AA23A7B6B5F7C5515026379272DD2
    Validators:     281D550ECD5DA99E4ADD9FE411299F6EB46B523B
    App:            65B64A51FF9F58D823C23CF034E24291FCEDD2BA
  }#75860B411898B6A27AA40C726DE119A070F40B5B
  Data{
    Tx:[118 97 108 58 48 49 51 51 68 68 55 66 48 51 54 49 70 50 69 53 65 70 65 53 52 53 52 65 50 52 56 51 55 52 68 56 57 69 53 51 49 70 53 67 54 68 52 53 70 67 66 70 65 66 52 68 67 50 67 57 51 65 53 70 50 70 67 53 70 57 47 49 48]
    Tx:[118 97 108 58 48 49 51 53 66 53 67 53 65 70 55 48 65 48 57 54 50 69 55 56 67 56 48 68 65 48 56 48 51 49 55 50 48 55 48 50 57 68 57 68 49 65 70 57 51 66 49 51 56 48 68 56 55 69 49 48 51 65 69 52 53 53 53 49 54 66 47 49 48]
  }#36721760CD4AA23A7B6B5F7C5515026379272DD2
  Commit{
    BlockID:    B52A7701AAFAB980B44D3C7415972FEEC8F7D942:1:E647A8FA90EA
    Precommits: Vote{0:2E957CF919E5 10/00/2(Precommit) B52A7701AAFA /41960BB76AFD.../}
    Vote{1:4F6BE1A4BB35 10/00/2(Precommit) B52A7701AAFA /4D2CAD15F4F1.../}
    Vote{2:531D483CB987 10/00/2(Precommit) B52A7701AAFA /F96C0ACD5514.../}
    Vote{3:C25E810EEBF0 10/00/2(Precommit) B52A7701AAFA /E88B7FCC6533.../}
    Vote{4:DFD0788E654F 10/00/2(Precommit) B52A7701AAFA /E651F413BF54.../}
  }#83F202126FBA458507F7E200DCCEE7E62E4474DD
}#75860B411898B6A27AA40C726DE119A070F40B5B module=consensus
INFO[12-23|13:02:46] Executed block                           module=stateheight=11 valid txs=2 invalid txs=0
INFO[12-23|13:02:46] Update to validator set                  module=stateupdates="[{\"pub_key\":\"0133DD7B0361F2E5AFA5454A248374D89E531F5C6D45FCBFAB4DC2C93A5F2FC5F9\",\"power\":10},{\"pub_key\":\"0135B5C5AF70A0962E78C80DA080317207029D9D1AF93B1380D87E103AE455516B\",\"power\":10}]"
INFO[12-23|13:02:46] Saved state                              module=dummyroot=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
NOTE[12-23|13:02:46] Saving block                             module=dummyheight=11 root=2719616B7C2585E000F5DFF1E2549061C5ED8AF1
INFO[12-23|13:02:46] Recheck txs                              module=mempool numtxs=0
INFO[12-23|13:02:46] Got block                                module=consensus height=11 validator=0
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]} module=consensus
NOTE[12-23|13:02:46] enterNewRound(12/0). Current: 12/0/RoundStepNewHeightmodule=consensus
INFO[12-23|13:02:46] enterPropose(12/0). Current: 12/0/RoundStepNewRound module=consensus
INFO[12-23|13:02:46] enterPropose: Not our turn to propose    module=consensus proposer=2E957CF919E5BAFFB9CFCABE470BFD85A03531F4 privValidator="PrivValidator{531D483CB9879AE41D8A8DE7E1F7AA4DED2E3AE2 LH:11, LR:0, LS:3}"
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]} module=consensus
NOTE[12-23|13:02:46] enterNewRound(12/0). Current: 12/0/RoundStepNewHeightmodule=consensus
INFO[12-23|13:02:46] enterPropose(12/0). Current: 12/0/RoundStepNewRound module=consensus
INFO[12-23|13:02:46] enterPropose: Not our turn to propose    module=consensus proposer=2E957CF919E5BAFFB9CFCABE470BFD85A03531F4 privValidator="PrivValidator{4F6BE1A4BB35859287F01F9021E1C699C5245866 LH:11, LR:0, LS:3}"
INFO[12-23|13:02:46] Added to lastPrecommits: VoteSet{H:11 R:0 T:2 +2/3:75860B411898B6A27AA40C726DE119A070F40B5B:1:F3BA2DCA105E BA{5:XXXXX} map[]} module=consensus
NOTE[12-23|13:02:46] enterNewRound(12/0). Current: 12/0/RoundStepNewHeightmodule=consensus
INFO[12-23|13:02:46] enterPropose(12/0). Current: 12/0/RoundStepNewRound module=consensus
INFO[12-23|13:02:46] enterPropose: Not our turn to propose    module=consensus proposer=2E957CF919E5BAFFB9CFCABE470BFD85A03531F4 privValidator="PrivValidator{DFD0788E654F8234A89DBA7539F75CEE1E9CA10A LH:11, LR:0, LS:3}"
--- FAIL: TestValidatorSetChanges (22.76s)
        reactor_test.go:229: Timed out waiting for all validators to commit a block

melekes · 2016-12-26T11:54:13Z

Interesting observation: if you comment out "changing the voting power" subtest, all other tests will pass.

melekes · 2017-01-05T13:16:34Z

Apparently, voting power could be negative:

WARN[01-05|13:09:18] execution                                module=statenextValSet="ValidatorSet{\n  Proposer: Validator{91D6FB5E0474FB8F76E8246D9F511
03077067E64 PubKeyEd25519{CB3CE8B6B6EDD2B4FEFE3EC759B77C8265B042D7BC4898484F1AD0ABE03DA3DF} 10 VP:-20 A:%!v(MISSING)}\n  Validators:\n    Validator{17DD
3CB8640E0C7BD30413250C9861BCD9BE5529 PubKeyEd25519{00858265AACF854DDDDCA1E67914124CAC47F3E45BFE1A18142D23C72FC54344} 10 VP:-20 A:%!v(MISSING)}\n   Valid
ator{91D6FB5E0474FB8F76E8246D9F51103077067E64 PubKeyEd25519{CB3CE8B6B6EDD2B4FEFE3EC759B77C8265B042D7BC4898484F1AD0ABE03DA3DF} 10 VP:-20 A:%!v(MISSING)}\
n    Validator{AE66B85AD768DE58BC55FDA2B3ECB08A1E8089C2 PubKeyEd25519{7B8DA7848C5EF73A152D907F17E0C6D844734AFE22A2F6506FC64A3C857E20B4} 10 VP:20 A:%!v(M
ISSING)}\n    Validator{C33225867B5A631DBA62502C2EC49933958BD078 PubKeyEd25519{E0159BB48E20E94DC521651E2382382984AAB6792FDF8ED2BF72AB8B3311F9E4} 10 VP:2
0 A:%!v(MISSING)}\n}"

what does that mean for validator? that it won't be allowed to propose a block?

ebuchman · 2017-01-06T04:23:34Z

Negative voting power! Oh boy. Don't think that should ever happen

Also deal with possible overflow issues.

ebuchman · 2017-01-11T15:54:24Z

Should have clued in earlier - the apparent negative voting power is a formatting issues (note the MISSING). See the mismatch here: https://github.com/tendermint/tendermint/blob/develop/types/validator.go#L64

That's my bad, I changed the validator struct and neglected to update the format string. I think that makes #354 unnecessary. This line should prevent negative voting powers: https://github.com/tendermint/tendermint/blob/develop/state/execution.go#L150

That said, I do like using types to enforce possible states whenever possible, so I'm not opposed to this. Will need @jaekwon to be final arbitrer on whether or not we should change the voting power to uint64

ebuchman · 2017-01-11T22:56:08Z

rebased and fixed halting issue here: #359

…package name (#344)

@shahankhatch

* Initial commit * Add three timeouts and align pseudocode better with existing algorithm * Align protocol with Tendermint code and add find valid value mechanism * Prepare to Nuke Develop (#47) * state -> step * vote -> v * New version of the algorithm and the proof * New version of the algorithm and the proofs * Added algorithm description * Add algorithm description * Add introduction * Add conclusion * Add conclusion file * fix warnings (caption was defined twice) - only the latter is used anyways (centers captions) - this makes it possible to autom. building the paper * Update grammar * s/state_p/step_p * Address Ismail's comments * intro: language fixes * definitions: language fixes * consensus: various fixes * proof: some fixes * try to improve reviewability * \eq -> = * textwrap to 79 * various minor fixes * proof: fix itemization * proof: more minor fixes * proof: timeouts are functions * proof: fixes to lemma6 * Intro changes and improve title page * Add Marko and Ming to acks * add readme * Format algorithm correctly Clarify condition semantic and timeouts Improve descriptions * patform -> platform * Ensure that rules are mutually exclusive - various clarifications and small improvements * Release v0.6 * small nits for smoother readability * This PR is to create signed commits to be able to merge (#50) Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add consesnus and blockchain specs, (#52) - Open questions - Do we want to split lite client work from consesnsus - From the blockchain spec, is encoding nessecary in the spec Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add ABCI SPEC (#51) - move the abci spec from tendermint to spec repo Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * spec/consensus/signing: add more details about nil and amnesia (#54) - Add more details about nil votes and about amnesia attacks Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Add Section for P2P (#53) * Add Section for P2P - moved over the section on p2p Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * add some more files Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Fix model section * Add non-recursive specification of Bisection algorithm - Fix timing issues by introducing Delta parameter * spec: update spec with tendermint updates (#62) * spec: update spec with tendermint updates - this in preperation of deleting the spec folder in docs in tendermint/tendermint Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * spec: added in reactors & p2p Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * spec: update readme in spec to comply with docs site Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * docs: addded more changes from tednermint/tendermint Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * reflect breaking changes made to Commit (#63) * reflect breaking changes made to Commit PR: #4146 Issue: #1648 * types: rename Commit#Precommits to Signatures * update BlockIDFlagAbsent comment * remove iota * Clean up error conditions and simplify pseudocode * Apply suggestions from code review Co-Authored-By: Anca Zamfir <ancazamfir@users.noreply.github.com> * Add spec doc about unconditional_peer, persistent_peers_max_dial of ADR-050 (#68) * Add spec doc about unconditional_peer_ids, persistent_peers_max_dial_period of ADR-050 * Add indefinitely dialing condition * Add sr25519 amino documentation (#67) * sr25519 amino * Update spec/blockchain/encoding.md Co-Authored-By: Marko <marbar3778@yahoo.com> * some suggestions for pseuodocode changes * Improved error handling * Add explanation on difference between trusted models * Address reviewer's comments * Addressing reviewer's comments * Separating algorithm from proofs * Intermediate commit (aligning spec with the code) * Removing Store from API and providing end-to-end timing guarantees * Address reviewer comment's. Intermediate commit * light client dir and readmes * titles * add redirects * add diagram * detection TODO * fix image * update readme * Aligh the correctness arguments with the pseudocode changes * lite->light * Fix link in readme ./light -> ./light-client * p2p: Merlin based malleability fixes (#72) * Update the secret connection spec with the use of merlin to eliminte handshake malleability * Update spec/p2p/peer.md Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> * Update spec/p2p/peer.md Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> * Update spec/p2p/peer.md Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * docs: update specs to remove cmn (#77) - cmn was remvoed in favor of sub pkgs. cmn.kvpair is now kv.pair Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * evidence: Add time to evidence params (#69) * evidence: Add time to evidence params - this pr is grouped together with #4254, once that PR is merged then this one can be as well. Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * remove note Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * Apply suggestions from code review Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * update link to the pex reactor * add markdown link checker * changed tab spacing * removed folder-path flag * first attempt at fixing all links * second attempt at fixing all links * codeowners: add code owners (#82) * codeowners: add code owners - added some codeowners please comment if youd like to be added as well. Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * remove comment of repo maintainers * remove .idea dir (#83) Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> * RFC-001: configurable block retention (#84) * Added RFC for truncated block history coordination * Clarified minimum block retention * Added hard checks on block retention and snapshot interval, and made some minor tweaks * Genesis parameters are immutable * Use local config for snapshot interval * Reordered parameter descriptions * Clarified local config option for snapshot-interval * rewrite for ABCI commit response * Renamed RFC * add block retention diagram * Removed retain_blocks table * fix image numbers * resolved open questions * image quality * accept RFC-001 (#86) * abci: add basic description of ABCI Commit.ResponseHeight (#85) Documentation for block pruning, once it's merged: #4588. Minimum documentation, for now - we probably shouldn't encourage using this feature too much until we release state sync. * abci: add MaxAgeNumBlocks/MaxAgeDuration to EvidenceParams (#87) * abci: update MaxAgeNumBlocks & MaxAgeDuration docs (#88) * document state sync ABCI interface and P2P protocol (#90) The corresponding Tendermint PRs are #4704 and #4705. * Revert "document state sync ABCI interface and P2P protocol (#90)" (#92) This reverts commit 9842b4b. * blockchain: change validator set sorting method (#91) * abci: specify sorting of RequestInitChain.Validators * blockchain: change validator sorting method Refs #2478 * reactors/pex: specify hash function (#94) https://github.com/tendermint/tendermint/pull/4810/files * document state sync ABCI interface and P2P protocol (#93) * Revert "Revert "document state sync ABCI interface and P2P protocol (#90)" (#92)" This reverts commit 90797ce. * update with new enum case * fix links Co-authored-by: Erik Grinaker <erik@interchain.berlin> * Update evidence params with MaxNum (#95) evidence params now includes maxNum which is the maximum number of evidence that can be committed on a single block * reactors/pex: masked IP is used as group key (#96) * spec: add ProofTrialPeriod to EvidenceParam (#99) * spec: modify Header.LastResultsHash (#97) Refs: #1007 PR: #4845 * spec: link to abci server implementations (#100) * spec: update evidence in blockchain.md (#108) now evidence reflects the actual evidence present in the tendermint repo * abci: add AppVersion to ConsensusParams (#106) * abci: tweak node sync estimate (#115) * spec/abci: expand on Validator#Address (#118) Refs #3732 * blockchain: rename to core (#123) * blockchain: remove duplicate evidence sections (#124) * spec/consensus: canonical vs subjective commit Refs #2769 * Apply suggestions from code review Co-authored-by: Igor Konnov <igor.konnov@gmail.com> * update spec with the removal of phantom validator evidence (#126) * bring blockchain back * add correct links * spec: revert event hashing (#132) * Evidence time is sourced from block time (#138) * RFC-002: non-zero genesis (#119) * abci: add ResponseInitChain.app_hash (#140) * update hashing of empty inputs, and initial block LastResultsHash (#141) * update evidence verification (#139) * accept RFC-002 (#142) * add description of arbitrary initial height (#135) * update ResponseInitChain.app_hash description (#143) * remove unused directories and update README (#145) This change removes unused directories (`papers` and `research`) and updates the README to reflect our strategy for merging the informalsystems/tendermint-rs specs into this repository. Partially addresses #121. * ci: add markdown linter (#146) * ci: add dependabot config (#148) * build(deps): bump gaurav-nelson/github-action-markdown-link-check from 0.6.0 to 1.0.7 (#149) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 0.6.0 to 1.0.7. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: add sections to abci (#150) * spec: update abci events (#151) * spec: extract light-client to its own directory (#152) Co-authored-by: Callum Waters <cmwaters19@gmail.com> * spec: remove evidences (#153) * add a stale bot (#134) * Current versions of light client specs from tendermint-rs (#158) * current versions of light client specs from tendermint-rs * markdown lint * linting * links * links * links Co-authored-by: Marko Baricevic <marbar3778@yahoo.com> * Fastsync spec from tendermint-rs (#157) * fastsync spec from tendermint-rs * fixed broken link * fixed linting * more fixes * markdown lint * move fast_sync to rust-spec Co-authored-by: Marko Baricevic <marbar3778@yahoo.com> * Update README.md (#160) * spec/reactors/mempool: batch txs per peer (#155) * spec/reactors/mempool: batch txs per peer Refs #625 * update * spec: Light client attack detector (#164) * start with new detection and evidence spec * more definitions at top * sketch of functions * pre post draft * evidence proof * typo * evidence theory polished * some TODOs resolved * more TODOs * links * second to last revision before PR * links * I will read once more and then make a PR * removed peer handling definitions * secondary * ready to review * detector ready for review * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * Update rust-spec/lightclient/detection/detection.md * skip-trace * PossibleCommit explained * Update rust-spec/lightclient/detection/detection.md Co-authored-by: Zarko Milosevic <zarko@informal.systems> * comments by Zarko * renamed and changed link in README Co-authored-by: Zarko Milosevic <zarko@informal.systems> * fixed an overlooked conflict (#167) * describe valset sorting according to v0.34 requirements (#169) * evidence: update data structures (#165) * fix markdown linter (#172) * TLA+ specs from MBT revision (#173) * remove setOption (#181) * spec: protobuf changes (#156) Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> * first check latest with secondary (#184) * Extending the blockchain specification (in the light client) to produce different ratios of faults (#183) * cleaning unused definitions * introduced the ratio of faulty processes * Update README.md (#185) * build(deps): bump gaurav-nelson/github-action-markdown-link-check from 1.0.7 to 1.0.8 (#188) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.7 to 1.0.8. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.7...e3c371c) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * spec: update light client verification to match supervisor (#171) * VDD renaming of verification spec + links fixed * latest() * backwards * added TODOs * link in old file to new name * better text * revision done. needs one more round of reading * renamed constants in 001 according to TLA+ and impl * ready for PR * forgot linting * Update rust-spec/lightclient/verification/verification_002_draft.md * Update rust-spec/lightclient/verification/verification_002_draft.md * added lightstore function needed for supervisor * added lightstore functions for supervisor * ident * Update rust-spec/lightclient/verification/verification_002_draft.md * github: issue template for proposals (#190) * Sequential Supervisor (#186) * move from tendermint-rs but needs discussion * markdown lint * TODO links replaced * links * links * links lint * Update rust-spec/lightclient/supervisor/supervisor.md * Update rust-spec/lightclient/supervisor/supervisor.md * Update rust-spec/lightclient/supervisor/supervisor.md * Update rust-spec/lightclient/supervisor/supervisor.md * moved peer handling definitions to supervisor * polishing * rename * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * changes to maintain StateVerified again * ready for changes in verification * start of supervisor * module name * fixed * more details * supevisor completed. Now I have to add function to verification * ready for review * tla comment * removed issues * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * intro text fixed * indentation * Update rust-spec/lightclient/supervisor/supervisor_001_draft.md * comment to entry points Co-authored-by: Marko Baricevic <marbar3778@yahoo.com> * RFC: adopt zip 215 (#144) Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Core: move validation & data structures together (#176) Co-authored-by: Callum Waters <cmwaters19@gmail.com> * docs: make blockchain not viewable (#211) * evidence: update data structures to reflect added support of abci evidence (#213) * encoding: add secp, ref zip215, tables (#212) * Detector English Spec ready (#215) Add detector English spec * add Ivy proofs (#210) * add Ivy proofs * fix docker-compose command * Light client detector spec in TLA+ and refactoring of light client verification TLA+ spec (#216) Add light client detector spec in TLA+ * abci: lastcommitinfo.round extra sentence (#221) * abci: add abci_version to requestInfo (#223) * BFT requires _less than_ 1/3 faulty validators (#228) Thanks fo spotting the imprecision in the text, @shahankhatch ! * Draft of evidence handling for discussion (#225) * start with accountability deliverable * problem statement * draft function * quite complete draft. ready to discuss with Igor * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * Update isolate-attackers_001_draft.md * ready for TLA+ to take over * isolate * isolateamnesiatodos * Update isolate-attackers_001_draft.md * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * Update rust-spec/lightclient/attacks/isolate-attackers_001_draft.md Co-authored-by: Igor Konnov <konnov@forsyte.at> * The TLA+ specification of the attackers detection (#231) * the working attackers isolation spec, needs more comments * the TLA+ spec of the attackers isolation * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#233) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.8 to 1.0.11. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.8...2a60e0f) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Computing attack types (#232) Add light attack evidence handling * Update README.md (#234) * p2p: update frame size (#235) Reflect the change made in #5805 The MTU (Maximum Transmission Unit) for Ethernet is 1500 bytes. The IP header and the TCP header take up 20 bytes each at least (unless optional header fields are used) and thus the max for (non-Jumbo frame) Ethernet is 1500 - 20 -20 = 1460 Source: https://stackoverflow.com/a/3074427/820520 * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#239) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.11 to 1.0.12. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.11...0fe4911) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * layout: add section titles (#240) * reactors: remove bcv1 (#241) * abci: rewrite to proto interface (#237) * Update supervisor_001_draft.md (#243) * spec: remove reactor section (#242) Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com> * non-critical bugfix in the TLA+ spec (found by new version of apalache) (#244) * params: remove block timeiota (#248) * proto: add files (#246) Co-authored-by: Erik Grinaker <erik@interchain.berlin> * proto: modify height int64 to uint64 (#253) * abci: note on concurrency (#258) Co-authored-by: Marko <marbar3778@yahoo.com> * spec: merge rust-spec (#252) * Fix list of RFCs (#266) * readme: cleanup (#262) * modify readme * add rfc and proto * add rust=spec back to avoid breakage * lint readme * genesis: Explain fields in genesis file (#270) * describe the genesis * Update spec/core/genesis.md Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Callum Waters <cmwaters19@gmail.com> * add wording on app_state * Update spec/core/genesis.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> * p2p: links (#268) * fix links * fix more links * Proposer-based timestamp specification (#261) * added proposer-based timestamp spec * Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update spec/consensus/proposer-based-timestamp/pbts_001_draft.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md Co-authored-by: Marko <marbar3778@yahoo.com> * Update spec/consensus/proposer-based-timestamp/pbts-algorithm_001_draft.md * Update spec/consensus/proposer-based-timestamp/pbts-sysmodel_001_draft.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> * fixes from PR Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> * abci: reorder sidebar (#282) * ABCI++ RFC (#254) * ABCI++ RFC This commit adds an RFC for ABCI++, which is a collection of three new phases of communication between the consensus engine and the application. Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch> * Fix bugs pointed out by @liamsi * Update rfc/004-abci++.md Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * Fix markdown lints * Update rfc/004-abci++.md Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> * Update rfc/004-abci++.md Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com> * Update rfc/004-abci++.md Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com> * Add information about the rename in the context section * Bold RFC * Add example for self-authenticating vote data * More exposition of the term IPC * Update pros / negatives * Fix sentence fragment * Add desc for no-ops Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com> * RFC: ReverseSync - fetching historical data (#224) * core: update a few sections (#284) * p2p: update state sync messages for reverse sync (#285) * Update README.md (#286) * rpc: define spec for RPC (#276) * add rpc spec and support outline * add json * add more routes remove unneeded ones * add rest of rpc endpoints * add jsonrpc calls * add more jsonrpc calls * fix blockchain * cleanup unused links and add links to repos * Update spec/rpc/README.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> * add missing param from consensus param * Update spec/rpc/README.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> * Update spec/rpc/README.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> * fix cast and add doc to readme Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Marko Baricevic <markobaricevic@Fergalicious.local> * A few improvements to the Ivy proof (#288) * Avoid quantifier alternation cycle The problematic quantifier alternation cycle arose because the definition of accountability_violation was unfolded. This commit also restructures the induction proof for clarity. * add count_lines.sh * fix typo and add forgotten complete=fo in comment Co-authored-by: Giuliano <giuliano@eic-61-11.galois.com> * Fixed a broken link (#291) * fix message type for block-sync (#298) * lint: fix lint errors (#301) * build(deps): bump actions/stale from 3 to 3.0.18 (#300) Bumps [actions/stale](https://github.com/actions/stale) from 3 to 3.0.18. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3...v3.0.18) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump actions/stale from 3.0.18 to 3.0.19 (#302) Bumps [actions/stale](https://github.com/actions/stale) from 3.0.18 to 3.0.19. - [Release notes](https://github.com/actions/stale/releases) - [Commits](actions/stale@v3.0.18...v3.0.19) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * rename HasVote to ReceivedVote (#289) * add a changelog to track changes (#303) * add a changelog to track changes * Update CHANGELOG.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> * rpc: clarify timestamps (#304) * clarify timestamps * changelog entry * Update spec/rpc/README.md Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> * rpc: add chunked genesis endpoint (#299) * rpc: add chunked genesis endpoint * fix lint * feedback * add info about error * fix lint Co-authored-by: marbar3778 <marbar3778@yahoo.com> * update ResponseCheckTx (#306) * rpc: Add totalGasUSed to block_results response (#308) * Add C++ code generation and test scenario (#310) * add parameters to byzantine send action * make net not trusted it's not necessary since for proofs Ivy will assume that the environment does not break action preconditions * use require instead of assume it seems that assume is not checked when other isolates call! * add comment * add comment * run with random seed * make domain model extractable to C++ * substitute require for assume assumes in an action are not checked when the action is called! I.e. they place no requirement on the caller; we're just assuming that the caller is going to do the right thing. This wasn't very important here but it leade to a minor inconsistency slipping through. * make the net isolate not trusted there was no need for it * add tendermint_test.ivy contains a simple test scenario that show that the specification is no vacuuous * update comment * add comments * throw if trying to parse nset value in the repl * add comment * minor refactoring * add new pex messages (#312) * build(deps): bump gaurav-nelson/github-action-markdown-link-check (#313) Bumps [gaurav-nelson/github-action-markdown-link-check](https://github.com/gaurav-nelson/github-action-markdown-link-check) from 1.0.12 to 1.0.13. - [Release notes](https://github.com/gaurav-nelson/github-action-markdown-link-check/releases) - [Commits](gaurav-nelson/github-action-markdown-link-check@1.0.12...1.0.13) --- updated-dependencies: - dependency-name: gaurav-nelson/github-action-markdown-link-check dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * update spec to reference currently used timestamp type (#317) * build(deps): bump actions/stale from 3.0.19 to 4 (#319) Bumps [actions/stale](https://github.com/actions/stale) from 3.0.19 to 4. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v3.0.19...v4) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * address discrepancies between spec and implementation (#322) * update proto files for release (#318) * stale bot: ignore issues (#325) * evidence: add section explaining evidence (#324) * statesync: new messages for gossiping consensus params (#328) * rpc: update peer format in specification in NetInfo operation (#331) * Update supervisor_001_draft.md (#334) * core: text cleanup (#332) * abci: clarify what abci stands for (#336) * abci: clarify what abci stands for * link to abci type protos. * abci: clarify connection use in-process (#337) * abci: clarify connection use in-process * Update abci.md * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * invert abci explanations * lint++ * lint++ * lint++ * lint++ Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * proto: move proto files under the correct directory related to their package name (#344) * abci.md fixup (#339) * abci: points of clarification ahead of v0.1.0 * lint++ * typo * lint++ * double word score * grammar * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update spec/abci/abci.md Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * pr feedback * wip * update non-zero status code docs * fix event description * update CheckTx description Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * Update supervisor_001_draft.md (#333) * Update supervisor_001_draft.md If the only node in the *FullNodes* set is the primary, that was just deemed faulty, we can't find honest primary. * Update supervisor_001_draft.md * light: update initialization description (#320) * apps.md fixups (#341) * wip * wip * wip * remove comments in favor of gh comments * wip * udpates to language, should must etc * Apply suggestions from code review Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * remove tendermint cache description Co-authored-by: M. J. Fromberger <fromberger@interchain.io> * proto: add tendermint go changes (#349) * add missed proto files * add abci changes * rename blockchain to blocksync * Update proto/tendermint/abci/types.proto Co-authored-by: Callum Waters <cmwaters19@gmail.com> Co-authored-by: Callum Waters <cmwaters19@gmail.com> * fix mockery generation script (#9094) Signed-off-by: Marko Baricevic <marbar3778@yahoo.com> Co-authored-by: Milosevic, Zarko <zare.milosevic@gmail.com> Co-authored-by: Milosevic, Zarko <zare.milosevic@sicpa.com> Co-authored-by: Zarko Milosevic <zarko@tendermint.com> Co-authored-by: Marko <marbar3778@yahoo.com> Co-authored-by: Zarko Milosevic <zarko@interchain.io> Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Anca Zamfir <ancazamfir@users.noreply.github.com> Co-authored-by: dongsamb <dongsamb@gmail.com> Co-authored-by: Sunny Aggarwal <sunnya97@gmail.com> Co-authored-by: Anca Zamfir <anca@interchain.io> Co-authored-by: Ethan Buchman <ethan@coinculture.info> Co-authored-by: Zarko Milosevic <zarko@informal.systems> Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com> Co-authored-by: Zaki Manian <zaki@tendermint.com> Co-authored-by: Erik Grinaker <erik@interchain.berlin> Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com> Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com> Co-authored-by: Igor Konnov <igor.konnov@gmail.com> Co-authored-by: Sean Braithwaite <brapse@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josef Widder <44643235+josef-widder@users.noreply.github.com> Co-authored-by: Andrey Kuprianov <59489470+andrey-kuprianov@users.noreply.github.com> Co-authored-by: Igor Konnov <konnov@forsyte.at> Co-authored-by: Sam Hart <sam@hxrts.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Giuliano <giuliano@losa.fr> Co-authored-by: Shahan Khatchadourian <shahan.k.code@gmail.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: istoilkovska <anili100@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Sam Kleinman <garen@tychoish.com> Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch> Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: Marko Baricevic <markobaricevic@Fergalicious.local> Co-authored-by: Giuliano <giuliano@eic-61-11.galois.com> Co-authored-by: Jordan Sexton <jordan@jordansexton.com> Co-authored-by: MengXiangJian <805442788@qq.com> Co-authored-by: Yixin Luo <18810541851@163.com> Co-authored-by: crypto-facs <84574577+crypto-facs@users.noreply.github.com> Co-authored-by: Giuliano <giuliano@galois.com> Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com> Co-authored-by: Mateusz Górski <goral09@users.noreply.github.com> Co-authored-by: M. J. Fromberger <fromberger@interchain.io> Co-authored-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>

Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems> (cherry picked from commit 4a4ddd1) Co-authored-by: Thane Thomson <connect@thanethomson.com>

melekes added 2 commits December 26, 2016 19:39

test validator set changes more extensively

9bd3eed

log stages to stdout

016c835

srmo mentioned this pull request Dec 29, 2016

Tendermint panics on TMSP App kill #347

Closed

melekes force-pushed the feature/validator-set-changes-tests branch from 63a41a9 to 016c835 Compare January 4, 2017 13:57

melekes added a commit to melekes/tendermint that referenced this pull request Jan 9, 2017

make VotingPower uint64 (Refs tendermint#344)

d90d725

Also deal with possible overflow issues.

melekes mentioned this pull request Jan 9, 2017

make VotingPower uint64 (Refs #344) #354

Closed

ebuchman closed this Jan 11, 2017

cmwaters pushed a commit that referenced this pull request Feb 11, 2022

proto: move proto files under the correct directory related to their …

41e6812

…package name (#344)

faddat referenced this pull request in notional-labs/tendermint Apr 3, 2023

Fix pull request template (#344)

4a4ddd1

Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Lasaro <lasaro@informal.systems>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validator set changes tests #344

Validator set changes tests #344

melekes commented Dec 23, 2016

melekes commented Dec 26, 2016

melekes commented Jan 5, 2017

ebuchman commented Jan 6, 2017

ebuchman commented Jan 11, 2017

ebuchman commented Jan 11, 2017

Validator set changes tests #344

Validator set changes tests #344

Conversation

melekes commented Dec 23, 2016

melekes commented Dec 26, 2016

melekes commented Jan 5, 2017

ebuchman commented Jan 6, 2017

ebuchman commented Jan 11, 2017

ebuchman commented Jan 11, 2017