contributing.md #393
Merged
contributing.md #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melekes
force-pushed
the
feature/CONTRIBUTING.md
branch
from
0f62f66
to
d696550
Compare
cmwaters
pushed a commit
that referenced
this pull request
Feb 11, 2022
faddat
referenced
this pull request
in notional-labs/tendermint
Apr 3, 2023
* docs: Archive Tendermint Core ADRs Signed-off-by: Thane Thomson <connect@thanethomson.com> * docs: Archive Tendermint Core RFCs Signed-off-by: Thane Thomson <connect@thanethomson.com> * Moving TM ADR images to the tendermint-core folder * doc: Add link to ADR template Signed-off-by: Thane Thomson <connect@thanethomson.com> * Apply suggestions from code review Co-authored-by: Daniel <daniel.cason@informal.systems> --------- Signed-off-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: lasarojc <lasaro@informal.systems> Co-authored-by: Daniel <daniel.cason@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One primary reason behind this: Github shows this a the top of the page when someone wants to create a PR - https://github.com/blog/1184-contributing-guidelines. Often, I see people creating PR against
masterbranch with the changes, which are already present in develop.