handshake replay through consensus using mockApp #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #408 +/- ##
===========================================
- Coverage 51.14% 50.29% -0.86%
===========================================
Files 37 38 +1
Lines 4452 4464 +12
===========================================
- Hits 2277 2245 -32
- Misses 1959 2022 +63
+ Partials 216 197 -19Continue to review full report at Codecov.
|
Closed
melekes
reviewed
Feb 18, 2017
consensus/state.go
Outdated
| cs := NewConsensusState(config, state, proxyApp, blockStore, mempool) | ||
|
|
||
| evsw := types.NewEventSwitch() | ||
| evsw.Start() |
state/execution.go
Outdated
| @@ -273,41 +269,81 @@ func (s *State) CommitStateUpdateMempool(proxyAppConn proxy.AppConnConsensus, bl | |||
| return nil | |||
| } | |||
|
|
|||
| // apply a nd commit a block, but with out all the state validation | |||
state/execution.go
Outdated
| } | ||
|
|
||
| // h.replayLastBlock(h.config, h.state, proxyApp.Consensus(), h.store) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #352
Related: #388, #347, #409
MempoolandBlockstoreinterfaces. Should we move these totypes?types.Txs.cs_wal_dir->cs_wal_file.consensus/test_data/build.shto allow selecting which data to make.many_blocks.cswaldata for testing handshake replay of many blocks.