Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handshake/replay through the consensus state using mock app #352

Closed
ebuchman opened this issue Jan 6, 2017 · 0 comments
Closed

handshake/replay through the consensus state using mock app #352

ebuchman opened this issue Jan 6, 2017 · 0 comments
Assignees
@ebuchman
Milestone
release 0.9

Comments

@ebuchman
Copy link
Contributor

ebuchman commented Jan 6, 2017

Currently we use special cases and extra logic in the handshake to sync store, state, and app. Instead, always run through the consensus state from the last height, possibly using a mock app.
@ebuchman ebuchman added this to the release 0.9 milestone Jan 6, 2017
@ebuchman ebuchman self-assigned this Jan 6, 2017
@ebuchman ebuchman mentioned this issue Jan 6, 2017
Merged
@ebuchman ebuchman modified the milestones: 0.8.1, release 0.9 Jan 19, 2017
@ebuchman ebuchman modified the milestones: release 0.9, 0.8.1 Feb 16, 2017
@ebuchman ebuchman mentioned this issue Feb 16, 2017
Merged
cmwaters added a commit that referenced this issue Feb 11, 2022
@cmwaters
pex: update pex messages (#352)
a524e95
troian pushed a commit to akash-network/tendermint that referenced this issue Mar 11, 2023
@mergify @lasarojc
Use the right code coverage definitions (tendermint#352) (tendermint#355
6abd3bf 
)

by moving the `codecov.yml` file from .github the root folder.

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit c906604)

Co-authored-by: Lasaro <lasaro@informal.systems>
faddat referenced this issue in notional-labs/tendermint Apr 3, 2023
@lasarojc
Use the right code coverage definitions (#352)
c906604 
by moving the `codecov.yml` file from .github the root folder.

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
adrianbrink pushed a commit to heliaxdev/tendermint that referenced this issue May 23, 2023
@mergify @lasarojc
Use the right code coverage definitions (tendermint#352) (tendermint#354
ad92080 
)

by moving the `codecov.yml` file from .github the root folder.

---

#### PR checklist

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code comments

(cherry picked from commit c906604)

Co-authored-by: Lasaro <lasaro@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebuchman ebuchman

Labels
None yet
Projects
None yet
Milestone
release 0.9
Development

No branches or pull requests
1 participant
@ebuchman