docs: master → docs-staging #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This pr removes amino from tendermint. Closes: #4278
* test-vectors for backwards compatibility: - copy & paste test-vectors from v0.33.5 to ensure backwards compatibility for vote's SignBytes * WIP: everything besides time seems to match :-/ * almost * Found the culprit: field nums weren't consecutive ints ... * fix order of partset header too * this last votes-related test can easily be fixed * some minor changes and fix last failing test * move proto types back to stdtime, fix various linting * use libs/protoio * remvoe commented code * add comments * fix tests * uncomment testscases * dont ignore error panic * fix signable test * fix happy path testing * fix comment Co-authored-by: Marko Baricevic <marbar3778@yahoo.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com> Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
## Description This pr fixes the spacing of the if statement. It was working but throwing warnings. this aims to resolve that Closes: #XXX
## Description This PR moves all proto files under one dir (`/proto`). The script to generate adding functionality to copy the files that still need to be in the same place. (abci & rpc) renames every proto package from `tendermint.proto.<pkg_name>` to `tendermint.<pkg_name>` Removes unneeded types in privval proto directory Closes: #XXX
## Description add tests for to/from proto for blockmeta and add validate basic test case. Closes: #XXX
## Description This PR removes options in picking different pubkey types. We don't support anything other than ed25519 so this was redundant. We only ever supported ed25519 keys so not sure why we exposed different options. Not sure if this needs a changelog entry ? Closes: #XXX
….7.0 (#5027) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.6.0 to 1.7.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/releases">github.com/prometheus/client_golang's releases</a>.</em></p> <blockquote> <h2>1.7.0 / 2020-06-17</h2> <ul> <li>[CHANGE] API client: Add start/end parameters to <code>LabelNames</code> and <code>LabelValues</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/767">#767</a></li> <li>[FEATURE] testutil: Add <code>GatherAndCount</code> and enable filtering in <code>CollectAndCount</code> <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/753">#753</a></li> <li>[FEATURE] API client: Add support for <code>status</code> and <code>runtimeinfo</code> endpoints. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/755">#755</a></li> <li>[ENHANCEMENT] Wrapping <code>nil</code> with a <code>WrapRegistererWith...</code> function creates a no-op <code>Registerer</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/764">#764</a></li> <li>[ENHANCEMENT] promlint: Allow Kelvin as a base unit for cases like color temperature. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/761">#761</a></li> <li>[BUGFIX] push: Properly handle empty job and label values. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/752">#752</a></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md">github.com/prometheus/client_golang's changelog</a>.</em></p> <blockquote> <h2>1.7.0 / 2020-06-17</h2> <ul> <li>[CHANGE] API client: Add start/end parameters to <code>LabelNames</code> and <code>LabelValues</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/767">#767</a></li> <li>[FEATURE] testutil: Add <code>GatherAndCount</code> and enable filtering in <code>CollectAndCount</code> <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/753">#753</a></li> <li>[FEATURE] API client: Add support for <code>status</code> and <code>runtimeinfo</code> endpoints. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/755">#755</a></li> <li>[ENHANCEMENT] Wrapping <code>nil</code> with a <code>WrapRegistererWith...</code> function creates a no-op <code>Registerer</code>. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/764">#764</a></li> <li>[ENHANCEMENT] promlint: Allow Kelvin as a base unit for cases like color temperature. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/761">#761</a></li> <li>[BUGFIX] push: Properly handle empty job and label values. <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/752">#752</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prometheus/client_golang/commit/b05e50c9298cbadd2b4be3f1527f5c1b178acb55"><code>b05e50c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/769">#769</a> from prometheus/beorn7/release</li> <li><a href="https://github.com/prometheus/client_golang/commit/cc5731c16cbea6ec23e3398f27ba14dc0ff7b709"><code>cc5731c</code></a> Cut v1.7.0</li> <li><a href="https://github.com/prometheus/client_golang/commit/3c8b15fa0d84373bf5e35c6a0f0626650c513b32"><code>3c8b15f</code></a> Update dependencies</li> <li><a href="https://github.com/prometheus/client_golang/commit/c304bb07a67e362c70d622b31bde26f57624916b"><code>c304bb0</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/767">#767</a> from Nexucis/feature/labelNames-parameter</li> <li><a href="https://github.com/prometheus/client_golang/commit/3defbd9c7c086d0b0d24b0e0f3db541cea084964"><code>3defbd9</code></a> add start/end parameter for LabelValues</li> <li><a href="https://github.com/prometheus/client_golang/commit/6ce5f2ca8ad23ffb3ed2389acc285bc04bdb0089"><code>6ce5f2c</code></a> add start/end parameter for LabelNames</li> <li><a href="https://github.com/prometheus/client_golang/commit/03575cad4e55adb37a5396afa7cc0eec43526740"><code>03575ca</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/prometheus/client_golang/issues/764">#764</a> from prometheus/wrap-nil</li> <li><a href="https://github.com/prometheus/client_golang/commit/9c8ba1f9451a222e7918818ecff91bac5626dd48"><code>9c8ba1f</code></a> Review feedback: add comment and tests for WrapRegistererWith.</li> <li><a href="https://github.com/prometheus/client_golang/commit/614377c5501cb1666a3b057dd23c094d6d13ab24"><code>614377c</code></a> Review feedback: use one line.</li> <li><a href="https://github.com/prometheus/client_golang/commit/8961609f911516b04f81ac75fc4b0e0b8e455c2e"><code>8961609</code></a> Ensure that nil registers are treat as a no-op, even when wrapping.</li> <li>Additional commits viewable in <a href="https://github.com/prometheus/client_golang/compare/v1.6.0...v1.7.0">compare view</a></li> </ul> </details> <br /> [](https://dependabot.com/compatibility-score/?dependency-name=github.com/prometheus/client_golang&package-manager=go_modules&previous-version=1.6.0&new-version=1.7.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) Dependabot will merge this PR once CI passes on it, as requested by @marbar3778. [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details>
## Description ignore autogen file codecov Closes: #XXX
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
## Description have the defined abci proto types follow the same directory structure as in abci folder. Closes: #XXX
depending on the votes order in DuplicateVoteEvidence is arbitrary. we should always choose the latest timestamp. Closes #5030
Co-authored-by: JamesRay <66258875@qq.com> making it possible to change app version via EndBlock
* types: reject blocks w/ ConflictingHeadersEvidence Closes #5037 * types: reject blocks w/ PotentialAmnesiaEvidence as well PotentialAmnesiaEvidence does not contribute anything on its own, therefore should not be committed on chain. * fix lint issue
fix bug so that PotentialAmnesiaEvidence is being gossiped handle inbound amnesia evidence correctly add method to check if potential amnesia evidence is on trial fix a bug with the height when we upgrade to amnesia evidence change evidence to using just pointers. More logging in the evidence module Co-authored-by: Marko <marbar3778@yahoo.com>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.29.1 to 1.30.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.29.1...v1.30.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/master/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.7.0...v1.7.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
also, - add an example for WS - mention that a subscription could be terminated in /subscribe Closes #5014
## Description Remove concurrent write access bug by removing the memoized string representation of a `NetAddress`. Closes: #5047
## Description - expand `upgrading.md` - alphabetize the changelog - update swagger with changes Closes: #XXX
## Description add a simple doc.go to behavior module Closes: #XXX
in `persistent_kvstore`
## Description Add a cmd to docker image and use it to format our proto files. This avoids developers the need to install clang-format Closes: #XXX
Closes #5145 also applies to light/client
also, document consensus parameters. https://forum.cosmos.network/t/consensus-timeouts-explained/1421 Closes #4489
Clean up some inconsistent formatting and missing PR numbers.
Cleans up the grammar, removes out-of-date information, and reduces false promises.
…ocs (#5390) Bumps [vuepress-theme-cosmos](https://github.com/cosmos/vuepress-theme-cosmos) from 1.0.172 to 1.0.173. - [Release notes](https://github.com/cosmos/vuepress-theme-cosmos/releases) - [Commits](https://github.com/cosmos/vuepress-theme-cosmos/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tess Rinearson <tess.rinearson@gmail.com>
This caused the node to crash whenever any state sync-related request was called via the ABCI UNIX socket client.
Reduces the state sync discovery time from 20 to 15 seconds, and makes it configurable.
This change adds some polish to the upgrading instructions for 0.34. The only substantive changes include: * Calling out ABCI-impacting changes explicitly in the "ABCI Changes" section, even if those changes are also mentioned elsewhere * Removes `ProofOfTrialPeriod` from consensus params; this change was introduced and then removed.
* docs: fix /validators description Refs tendermint/spec#169 * consensus: remove nil err from logging statement * update UPGRADING.md * note about LightBlocks
## Description Add simple `NoBlockResponse` handling to blockchain reactor v1. I tested before and after with erik's e2e testing and was not able to reproduce the inability to sync after the changes were applied Closes: #5394
## Description Add information on p2p settings in documentation Closes: #XXX
previously, the second next could return nil, which would be the reason for panic on line 275: memTx := next.Value.(*mempoolTx) Closes #5408
lovincyrus
requested review from
ebuchman,
melekes and
tessr
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To update: https://docs.staging-tendermint.com