block: use commit sig size instead of vote size #5490

cmwaters · 2020-10-12T17:13:55Z

Description

Closes: #5448

…/tendermint into marko/varint_length_tx

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

codecov · 2020-10-12T19:22:48Z

Codecov Report

Merging #5490 into master will increase coverage by 1.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5490      +/-   ##
==========================================
+ Coverage   59.90%   61.04%   +1.13%     
==========================================
  Files         210      261      +51     
  Lines       18273    23617    +5344     
==========================================
+ Hits        10947    14416    +3469     
- Misses       6231     7731    +1500     
- Partials     1095     1470     +375

Impacted Files	Coverage Δ
types/vote.go	`89.10% <ø> (ø)`
types/block.go	`73.69% <100.00%> (+0.09%)`	⬆️
libs/events/events.go	`92.94% <0.00%> (-5.89%)`	⬇️
consensus/reactor.go	`74.08% <0.00%> (-2.52%)`	⬇️
blockchain/v0/reactor.go	`60.59% <0.00%> (-0.99%)`	⬇️
consensus/state.go	`68.44% <0.00%> (-0.29%)`	⬇️
privval/signer_server.go	`94.73% <0.00%> (ø)`
mempool/clist_mempool.go	`83.83% <0.00%> (ø)`
node/id.go	`0.00% <0.00%> (ø)`
privval/file.go	`68.68% <0.00%> (ø)`
... and 48 more

types/block_test.go

types/block.go

* mempool: length prefix txs when getting them from mempool (#5483) * correctly calculate evidence data size (#5482) * block: use commit sig size instead of vote size (#5490) * tx: reduce function to one parameter (#5493)

cmwaters and others added 20 commits October 9, 2020 18:25

fix evidence size count

0244c50

extend proposal block test

95e8eda

remove hash from evidence data proto

715bd7d

debugging

1a394ce

varint length prefix txs

41cb6b2

fix test & precheck bytes

d7ff155

fix spelling

358c76f

fix tests

7d3899a

Merge branch 'master' into marko/varint_length_tx

fdd30d6

encode using Uvarint

5f84c45

compare hashes instead of concrete struct

181a0fc

Update node/node_test.go

da55936

varint encode

5a2ff08

erge branch 'marko/varint_length_tx' of https://github.com/tendermint…

76738e5

…/tendermint into marko/varint_length_tx

account for field num

4528ce6

add in godoc

bf4b85b

Merge branch 'master' into marko/varint_length_tx

a6acc80

Update types/tx.go

31bf667

Co-authored-by: Callum Waters <cmwaters19@gmail.com>

calculate commit size instead of vote sizes

8c100fa

fix test

bd4c4a9

make tests pass

fa4700f

tac0turtle force-pushed the callum/more-sizing-stuff branch from 813ae2b to fa4700f Compare October 13, 2020 08:32

cmwaters added 2 commits October 13, 2020 12:41

Merge branch 'master' into callum/more-sizing-stuff

3ab28f5

clean up

d9aa5a3

cmwaters marked this pull request as ready for review October 13, 2020 12:28

cmwaters requested review from ebuchman, erikgrinaker, melekes and tessr as code owners October 13, 2020 12:28

tac0turtle reviewed Oct 13, 2020

View reviewed changes

types/block_test.go Show resolved Hide resolved

erikgrinaker reviewed Oct 13, 2020

View reviewed changes

types/block_test.go Outdated Show resolved Hide resolved

remove redundant tests and fix MaxCommitBytes function

e1d8e74

erikgrinaker approved these changes Oct 13, 2020

View reviewed changes

gofmt

9caa02d

melekes reviewed Oct 13, 2020

View reviewed changes

types/block.go Show resolved Hide resolved

types/block.go Outdated Show resolved Hide resolved

add comment

14205c6

cmwaters merged commit 55e8cca into master Oct 13, 2020

cmwaters deleted the callum/more-sizing-stuff branch October 13, 2020 15:21

cmwaters added a commit that referenced this pull request Oct 13, 2020

block: use commit sig size instead of vote size (#5490)

ce6dac2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

block: use commit sig size instead of vote size #5490

block: use commit sig size instead of vote size #5490

cmwaters commented Oct 12, 2020

codecov bot commented Oct 12, 2020 •

edited

Loading

block: use commit sig size instead of vote size #5490

block: use commit sig size instead of vote size #5490

Conversation

cmwaters commented Oct 12, 2020

Description

codecov bot commented Oct 12, 2020 • edited Loading

Codecov Report

codecov bot commented Oct 12, 2020 •

edited

Loading