Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify Reactor priorities #5826

Merged
merged 5 commits into from
Dec 23, 2020
Merged

modify Reactor priorities #5826

merged 5 commits into from
Dec 23, 2020

Commits on Dec 23, 2020

  1. modify Reactor priorities 

    blockchain/vX reactor priority was decreased because during a normal operation
(i.e. when the node is not fast syncing) blockchain priority can't be
the same as consensus reactor. Otherwise, it's theoretically possible to
slow down consensus by constantly requesting blocks from the node.

NOTE: ideally blockchain/vX reactor priority would be dynamic. e.g. when
the node is fast syncing, the priority is 10 (max), but when it's done
fast syncing - the priority gets decreased to 5 (only to serve blocks
for other nodes). But it's not possible now, therefore I decided to
focus on normal operation (priority = 5).

evidence and consensus critical messages are more important than
mempool, hence they are increased by 1 (from 5 to 6).

statesync reactor priority was changed from 1 to 5 to be the same as
blockchain/vX priority.
    @melekes
    melekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    56908ee View commit details
    Browse the repository at this point in the history

  2. bump VoteChannel priority

    @melekes
    melekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    e88d6fa View commit details
    Browse the repository at this point in the history

  3. fix statesync priorities

    @melekes
    melekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    79a0038 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into anton/p2p-priorities

    @melekes
    melekes committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    85cc31c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into anton/p2p-priorities

    @mergify
    mergify[bot] committed Dec 23, 2020
    Configuration menu
    Copy the full SHA
    f8849fe View commit details
    Browse the repository at this point in the history