-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc/client/http: drop endpoint arg from New and add WSOptions #6176
Conversation
if a write does not come through after 10s, the client will disconnect from the server.
Codecov Report
@@ Coverage Diff @@
## master #6176 +/- ##
==========================================
+ Coverage 60.67% 60.86% +0.19%
==========================================
Files 276 276
Lines 25716 25712 -4
==========================================
+ Hits 15602 15650 +48
+ Misses 8486 8447 -39
+ Partials 1628 1615 -13
|
@hydrogen18 how does this new API look to you? (re #6162) |
@melekes Ok wow this is larger than I anticipated but it gives an easy way to pass in the options for the web socket connection so this is great! Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - also nice that you cleaned up a few things here and there. I just have a few comments that you might want to address but other than that if everyone else is happy with the solution then we should be good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Are we sure we updated all RPC/websocket documentation with the new API? Also, do we not need to update the changelog with the new breaking API changes?
also
MaxReconnectAttempts
,ReadWait
,WriteWait
andPingPeriod
options withWSOptions
inWSClient
(rpc/jsonrpc/client/ws_client.go).WSClient
(rpc/jsonrpc/client/ws_client.go)WSEvents
(rpc/client/http.go)Closes #6162