-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: add sr25519 as a validator key #6376
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
commented
Apr 20, 2021
tac0turtle
requested review from
alexanderbez,
ebuchman,
tessr and
tychoish
as code owners
April 20, 2021 14:30
tac0turtle
requested review from
cmwaters and
alexanderbez
and removed request for
alexanderbez
April 20, 2021 14:30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
alexanderbez
suggested changes
Apr 20, 2021
alexanderbez
approved these changes
Apr 21, 2021
Does this test failing have anything to do with your changes:
|
Codecov Report
@@ Coverage Diff @@
## master #6376 +/- ##
==========================================
+ Coverage 60.58% 60.82% +0.24%
==========================================
Files 283 283
Lines 26917 26925 +8
==========================================
+ Hits 16307 16378 +71
+ Misses 8893 8844 -49
+ Partials 1717 1703 -14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sr25519 as a validator key option. We support the crypto in tendermint and added batch verification recently.