Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abci++: Sync implementation and spec for vote extensions #8141
abci++: Sync implementation and spec for vote extensions #8141
Changes from 11 commits
8fbe537
116bbf0
ce54bf3
da4fedc
c978c29
306d568
aac3df4
71d3695
19e07c9
9431db9
ab50582
25a7312
e0ca454
65f1902
4b62616
0527731
dfe8243
040cb56
f3188e5
9951b7a
806e348
617f47f
cbe8560
01b6a4f
fab3cd0
620c323
f618fc2
d9b2859
a03504d
730b245
3fabdee
27c920c
4ddc46e
3be1b6a
f3d8529
7d1f928
685487a
a8505f0
b8e0e0b
c9921eb
b06d274
989c9b6
b958ca2
431c85b
a682cc8
16b67fd
eedb750
1488a90
8938553
9b12360
28cd854
a371c86
f697844
3a158ce
a3f0123
2bc6c4c
e7e8061
63c32c4
2ccd305
c1c8ca9
26f049a
af6d500
3124ac5
e7523c4
5502162
8bb7983
5884ce5
50fc899
b054c42
35aa879
532a0f9
c420dd4
298a6b2
8104cf5
b3b74df
43f4f5c
d2d8748
8b104e4
a07ae24
68245d7
77ac2b3
c89890b
cb97056
faec1d3
61899b2
e4dd691
ed7daa9
1512b23
ec30866
a25fbe0
916d475
a840495
ea464c7
bc4a40d
abdb000
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd probably be a good idea to merge with master at this point, to get #8158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider keeping these (in some form), after merging