ABCI++: Update new protos to use enum instead of bool #8158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williambanfield
requested review from
josef-widder,
milosevic,
cason,
ebuchman,
cmwaters,
tychoish,
creachadair,
sergio-mena,
jmalicevic,
thanethomson and
ancazamfir
as code owners
creachadair
approved these changes
Mar 18, 2022
sergio-mena
approved these changes
Mar 21, 2022
williambanfield
added
the
S:automerge
|
@thanethomson heads up, this change now re-orders the |
Great stuff! 👍 |
35 tasks
17 tasks
williambanfield
added a commit
that referenced
this pull request
Sep 9, 2022
closes: #8039 This pull request updates the new ABCI++ protos to use `enum`s in place of `bool`s. `enums` may be preferred over `bool` because an `enum` can be udpated to include new statuses in the future, whereas a `bool` cannot and is fixed as just `true` or `false` over the whole lifecycle of the API.
This was referenced Dec 19, 2022
This was referenced Jan 11, 2023
faddat
pushed a commit
to notional-labs/tendermint
that referenced
this pull request
Apr 3, 2023
* [cherry-picked] ABCI++: Update new protos to use enum instead of bool (tendermint#8158) This pull request updates the new ABCI++ protos to use `enum`s in place of `bool`s. `enums` may be preferred over `bool` because an `enum` can be udpated to include new statuses in the future, whereas a `bool` cannot and is fixed as just `true` or `false` over the whole lifecycle of the API. * Detect and handle UNKNOWN in `ResponseVerifyVoteExtension` Co-authored-by: William Banfield <4561443+williambanfield@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #8039
This pull request updates the new ABCI++ protos to use
enums in place ofbools.enumsmay be preferred overboolbecause anenumcan be udpated to include new statuses in the future, whereas aboolcannot and is fixed as justtrueorfalseover the whole lifecycle of the API.