-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete abci methods, no longer called by ABCI++ Tendermint #8633
Conversation
The reasoning here makes sense, but I wonder: Do we need to worry about being able to read stored responses in order to validate old blocks? I seem to recall we do rely on some of the ABCI response data being persisted in order to deal with synchronization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems good but fix lint
Are you thinking of The rest of the protobuf data structures deleted in this PR are just not used elsewhere in the "manually generated" code. |
Yes, and I wasn't sure if there were others. |
At a first stage, we had decided to leave
BeginBlock
,DeliverTx
,EndBlock
in the ".proto" file, marked as deprecated. However, since Tendermint will not be calling them, an App developer might be tempted to implement them, which would result in dead code.This PR removes those ABCI methods from the ".proto" file.
The PR also adds a link to ABCI++ spec in the "UPGRADING.md" file, as a preliminary step to documenting the upgrade process.