node: always start blocksync and avoid misconfiguration #8902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tychoish
requested review from
ebuchman,
cmwaters,
williambanfield and
creachadair
as code owners
|
Is blocksync intended to always be enabled in v0.35? It looks like the option is still present to disable it. |
I can't see a reason why you'd ever want to disable it, and nothing really changed in 0.36 to support force enabling it. |
creachadair
reviewed
Jun 29, 2022
| @@ -700,10 +700,8 @@ func (n *nodeImpl) OnStart() error { | |||
| } | |||
|
|
|||
| if n.config.Mode != config.ModeSeed { | |||
| if n.config.BlockSync.Version == config.BlockSyncV0 { | |||
There was a problem hiding this comment.
Maybe at this point we should just remove this setting from the config file entirely? At least at master and maybe in v0.36 that seems safe.
There was a problem hiding this comment.
I believe it's out in master and 0.36 this is just against 0.35
creachadair
approved these changes
Jun 30, 2022
|
I don't think we should change this in the released version. |
williambanfield
pushed a commit
that referenced
this pull request
Jun 30, 2022
williambanfield
pushed a commit
that referenced
this pull request
Jun 30, 2022
williambanfield
added a commit
that referenced
this pull request
Jul 13, 2022
This reverts commit 204281f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #8899