-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
abci: implement vote extensions #9620
Conversation
I just finished doing the diff-of-diffs comparison between the branch with the cherry-picked commits and this PR, which has been rebased to the tip of the feature branch, and now also contains #9532. This experience was much better than
The way I am planning to move forward is the following:
|
* Obvious changes (including bugs) * Update privval/file.go Co-authored-by: Thane Thomson <connect@thanethomson.com> Co-authored-by: Thane Thomson <connect@thanethomson.com>
…locksync reactor (#9926) * Fix problems in blocksync reactor logic & test the fixes * diagnose messages on TestCheckSwitchToConsensusLastHeightZero * Fixed test logic * Apply suggestions from code review Co-authored-by: Lasaro <lasaro@informal.systems> * Addressed @lasarojc's comments Co-authored-by: Lasaro <lasaro@informal.systems>
…9927) * Make mempool v1 UTs more predictable * Simple changes * Reuse new signVote tests in production code * Fix `IsNil` problem from cherry-pick: should be `IsZero` * Fix linter issue * Apply suggestions from code review Co-authored-by: Lasaro <lasaro@informal.systems> * Addressed @lasarojc's comment * Addressed @jmalicevic's comment Co-authored-by: Lasaro <lasaro@informal.systems>
All the differences between this PR and branch |
This builds on top of #9532 and is part of
feature/abci++vef
This PR traces through the following PRs trying to make the appropriate changes on top of
main
ref: #9396
PR checklist
CHANGELOG_PENDING.md
updated, or no changelog entry neededdocs/
) and code comments, or nodocumentation updates needed