This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Send RemoteSignerError response on double sign (closes #249) #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously double signing would abort the connection. However, there is a semi-valid use case for returning an error message instead: when concurrent validators on the same chain are sending signing messages. This was proposed by @mdyring in #249. Ideally there should be coordination (i.e. between KMS instances) as to which validator is currently active, as this approach depends critically on the KMS's double signing prevention and encourages configurations where multiple validator instances are attempting to sign simultaneously. This runs the risk that a bug in the KMS's double signing detection could be singularly responsible for a double sign event. However, without something like this, it isn't possible for the KMS to service two validators simultaneously, so this seems like an OK start.
tarcieri
commented
Jun 21, 2019
|
|
||
| /// Error codes for remote signer failures | ||
| // TODO(tarcieri): add these to Tendermint. See corresponding TODO here: | ||
| // <https://github.com/tendermint/tendermint/blob/master/privval/errors.go> |
There was a problem hiding this comment.
@liamsi FYI... adding some remote signer error codes
|
Going to get another alpha out with this so I can test it more easily. Please review though! Seems we've never sent error responses back to Tendermint before so this will be interesting. Will address any review feedback before a final release. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously double signing would abort the connection.
However, there is a semi-valid use case for returning an error message instead: when concurrent validators on the same chain are sending signing messages. This was proposed by @mdyring in #249.
Ideally there should be coordination (i.e. between KMS instances) as to which validator is currently active, as this approach depends critically on the KMS's double signing prevention and encourages configurations where multiple validator instances are attempting to sign simultaneously. This runs the risk that a bug in the KMS's double signing detection could be singularly responsible for a double sign event.
However, without something like this, it isn't possible for the KMS to service two validators simultaneously, so this seems like an OK start with some nice HA benefits.