You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 15, 2018. It is now read-only.
tm-bench has an issue in the sense that it may receive a block with txs after it's finished (because of the network) when the block was in fact created within this T sec, hence should be included in the results.
Solutions
1. Wait for a final non-empty block from TM
To calculate stats correctly, we can wait for the last non-empty block from TM (we just need to check block creation time to make sure it was created within period T sec).
2. Fetch the blocks TM processed within the measurement period (T sec)
Or, we can completely abandon subscribe and fetch blocks using RPC again until we hit an empty block.
I think we should go with whatever is an easier option.
The text was updated successfully, but these errors were encountered:
Problem
tm-bench has an issue in the sense that it may receive a block with txs after it's finished (because of the network) when the block was in fact created within this T sec, hence should be included in the results
.Solutions
1. Wait for a final non-empty block from TM
To calculate stats correctly, we can wait for the last non-empty block from TM (we just need to check block creation time to make sure it was created within period T sec).
2. Fetch the blocks TM processed within the measurement period (T sec)
Or, we can completely abandon
subscribe
and fetch blocks using RPC again until we hit an empty block.I think we should go with whatever is an easier option.
The text was updated successfully, but these errors were encountered: