fix: v0 user passwd, add test for root permission (#1379)

Signed-off-by: Keming <kemingy94@gmail.com> Signed-off-by: Keming <kemingy94@gmail.com>
tensorchord · Jan 5, 2023 · 3c38b5e · 3c38b5e
1 parent 51b586e
commit 3c38b5e
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 3 deletions.
diff --git a/e2e/v0/language/runtime_test.go b/e2e/v0/language/runtime_test.go
@@ -32,5 +32,9 @@ var _ = Describe("runtime", Ordered, func() {
 		Expect(err).To(BeNil())
 		Expect(res).To(Equal("[2 3 4]"))
 	})
+	It("execute runtime command `root`", func() {
+		_, err := e.ExecRuntimeCommand("root")
+		Expect(err).To(BeNil())
+	})
 	AfterEach(e.DestroyContainer())
 })
diff --git a/e2e/v0/language/testdata/runtime/build.envd b/e2e/v0/language/testdata/runtime/build.envd
@@ -6,4 +6,9 @@ def build():
         ]
     )
     shell("zsh")
-    runtime.command(commands={"numpy": "python demo.py"})
+    runtime.command(
+        commands={
+            "numpy": "python demo.py",
+            "root": "sudo ls /root",
+        }
+    )
diff --git a/e2e/v1/language/runtime_test.go b/e2e/v1/language/runtime_test.go
@@ -32,5 +32,9 @@ var _ = Describe("runtime", Ordered, func() {
 		Expect(err).To(BeNil())
 		Expect(res).To(Equal("[2 3 4]"))
 	})
+	It("execute runtime command `root`", func() {
+		_, err := e.ExecRuntimeCommand("root")
+		Expect(err).To(BeNil())
+	})
 	AfterEach(e.DestroyContainer())
 })
diff --git a/e2e/v1/language/testdata/runtime/build.envd b/e2e/v1/language/testdata/runtime/build.envd
@@ -10,4 +10,9 @@ def build():
         ]
     )
     shell("zsh")
-    runtime.command(commands={"numpy": "python demo.py"})
+    runtime.command(
+        commands={
+            "numpy": "python demo.py",
+            "root": "sudo ls /root",
+        }
+    )
diff --git a/pkg/lang/ir/v0/user.go b/pkg/lang/ir/v0/user.go
@@ -66,7 +66,7 @@ func (g *generalGraph) compileUserGroup(root llb.State) llb.State {
 		res = root.
 			Run(llb.Shlexf(`groupadd -g %d envd`, g.gid),
 				llb.WithCustomName("[internal] create user group envd")).
-			Run(llb.Shlexf(`useradd -p \\ -u %d -g envd -s /bin/sh -m envd`, g.uid),
+			Run(llb.Shlexf(`useradd -p "" -u %d -g envd -s /bin/sh -m envd`, g.uid),
 				llb.WithCustomName("[internal] create user envd")).
 			Run(llb.Shlex("adduser envd sudo"),
 				llb.WithCustomName("[internal] add user envd to sudoers")).