Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update env client to support multiple envs #1052

Merged
merged 3 commits into from
Oct 20, 2022
Merged

feat: Update env client to support multiple envs #1052

merged 3 commits into from
Oct 20, 2022

Conversation

gaocegege
Copy link
Member

Ref #1027

@gaocegege
feat: Update env client to support multiple envs
941be89 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
chore: Update vendor
3be623a 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@gaocegege
fix: Update envd-server
81f70c0 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
@muniu-bot muniu-bot bot added the approved label Oct 19, 2022
@gaocegege
Copy link
Member Author

/assign @VoVAllen @kemingy

@gaocegege
Copy link
Member Author

@kemingy PTAL, thanks

kemingy
kemingy approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@kemingy kemingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muniu-bot
Copy link

muniu-bot bot commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, kemingy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege gaocegege merged commit 044d89e into tensorchord:main Oct 20, 2022
@gaocegege gaocegege deleted the multi branch October 20, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kemingy kemingy kemingy approved these changes

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees

@VoVAllen VoVAllen

@kemingy kemingy

Labels
approved
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaocegege @kemingy @VoVAllen