feat: add name to envd envs describe
#1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
kemingy
requested changes
Nov 15, 2022
gaocegege
reviewed
Nov 15, 2022
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
|
Addressed the comments and moved label name fetching logic to |
kemingy
reviewed
Nov 16, 2022
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
kemingy
reviewed
Nov 16, 2022
AlexXi19
added a commit
to AlexXi19/envd
that referenced
this pull request
Dec 12, 2022
* feat: add name to envd envs describe Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: move label name logic to ListEnvPortBinding Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: move label logic to NewPortBindingFromContainerJson Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: add name to envdserver port binding Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
gaocegege
pushed a commit
that referenced
this pull request
Dec 13, 2022
* feat: add name to `envd envs describe` (#1201) * feat: add name to envd envs describe Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: move label name logic to ListEnvPortBinding Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: move label logic to NewPortBindingFromContainerJson Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: add name to envdserver port binding Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * feat: interactive cli option selection Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * feat: cli write file Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * feat: add style and finish file gen Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * refactor: clean up demo.go Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * refactor: refactor functions to interactive.go Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: change color, add file check, properly exit Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * feat: merge interactive cli logic with init command Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * fix: remove envd demo command Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * fix: linting Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: remove init tests for interactive cli Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: remove more init tests Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: indent to const and remove init tests Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: return error Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AlexXi19 alex2001314jjj@gmail.com
#551
Show service name in ports list as specified by the issue.
Testing
Inspected
envd envs describefor both jupyter notebook and R studio and verified that the names are correct.