-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive cli #1294
Merged
Merged
Interactive cli #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add name to envd envs describe Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: move label name logic to ListEnvPortBinding Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: move label logic to NewPortBindingFromContainerJson Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> * chore: add name to envdserver port binding Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com> Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
AlexXi19
requested review from
gaocegege,
aseaday and
zwpaper
as code owners
December 12, 2022 03:27
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
Is it ready to review? |
Yes I think so |
kemingy
reviewed
Dec 12, 2022
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
@kemingy addressed the comments, please take a look! |
kemingy
previously approved these changes
Dec 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
gaocegege
reviewed
Dec 12, 2022
Signed-off-by: AlexXi19 <alex2001314jjj@gmail.com>
/lgtm Thanks for your contribution! 🎉 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#706
messed up the git history for the previous pr
Interactive CLI to generate
build.envd
(Proof of Concept)Asks user questions and generates
build.envd
based on the user's answersUsed bubbletea to create the TUI and bubbles to style the TUI.
Supports single selection and multiple selection.
Interface for the developers
Create a data structure to define a new question
Add question to
demoCommand
, further define question flow using conditional statements. The user's selection will be added toselectionMap
using your defined label.Use the user's selection from
selectionMap
and add your codegen logic togenerateFile
Demo
Testing
Can add testing later after finalizing the choices.