Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rm redundant ForwardAgent config in ssh config #1458

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: rm redundant ForwardAgent config in ssh config #1458

merged 1 commit into from
Feb 1, 2023

Conversation

kemingy
Copy link
Member

@kemingy kemingy commented Feb 1, 2023

Signed-off-by: Keming kemingyang@tensorchord.ai

@kemingy
fix: rm redundant ForwardAgent config in ssh config
229bb35 
Signed-off-by: Keming <kemingyang@tensorchord.ai>
@kemingy kemingy marked this pull request as ready for review February 1, 2023 09:51
@VoVAllen
Copy link
Member

VoVAllen commented Feb 1, 2023 •
edited
Loading

Why is it redundant?

@kemingy
Copy link
Member Author

kemingy commented Feb 1, 2023

Why is it redundant?

Duplicated with

envd/pkg/ssh/config/entry.go

Line 79 in dc5cbfa

newParam(forwardAgentKeyword, []string{"yes"}, nil))

@VoVAllen VoVAllen merged commit 89383b5 into tensorchord:main Feb 1, 2023
@kemingy kemingy deleted the rm_ssh_redudant branch February 1, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseaday aseaday Awaiting requested review from aseaday aseaday is a code owner

@zwpaper zwpaper Awaiting requested review from zwpaper zwpaper is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemingy @VoVAllen