feat(vscode): Support VSCode remote ssh plugins #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaocegege
commented
Apr 24, 2022
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
gaocegege
changed the title
gaocegege
changed the title
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
VoVAllen
approved these changes
Apr 25, 2022
| } | ||
| ext := llb.Scratch().File(llb.Copy(llb.Local(flag.FlagCacheDir), | ||
| vscodeClient.PluginPath(p), | ||
| "/root/.vscode-server/extensions/"+p.String(), |
There was a problem hiding this comment.
Not sure whether we should choose /root/ as the default directory. What's the common practise for the user when using docker? Does people use root or create other users?
There was a problem hiding this comment.
Yeah. I do not think it is a good practice to use root. We should manage the attack surface. I will open an issue to keep track of the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish.extensionname-version.vsixinto the host$HOME/.midi/cacheFix #18
Ref #51