Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add auto start buildkit container #563

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

aseaday
Copy link
Member

@aseaday aseaday commented Jul 6, 2022

Signed-off-by: Qi Chen aseaday@hotmail.com

Signed-off-by: Qi Chen <aseaday@hotmail.com>
@aseaday
Copy link
Member Author

aseaday commented Jul 6, 2022

This is the first patch of #561.
We may need more talk.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach LGTM.

/cc @kemingy @VoVAllen

Signed-off-by: Qi Chen <aseaday@hotmail.com>
@aseaday
Copy link
Member Author

aseaday commented Jul 7, 2022

This is the first patch of #561. We may need more talk.

Add rp restart always for current stage workaround.

@gaocegege
Copy link
Member

LGTM, I am merging it.

@gaocegege gaocegege merged commit 49fa961 into tensorchord:main Jul 7, 2022
@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@aseaday aseaday deleted the bug/auto_start_buildkit branch July 7, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants