Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Fix github action #566

Merged
merged 1 commit into from
Jul 7, 2022
Merged

bug: Fix github action #566

merged 1 commit into from
Jul 7, 2022

Conversation

VoVAllen
Copy link
Member

@VoVAllen VoVAllen commented Jul 7, 2022

Signed-off-by: Jinjing.Zhou allenzhou@tensorchord.ai

Fix #565

Signed-off-by: Jinjing.Zhou <allenzhou@tensorchord.ai>
@kemingy
Copy link
Member

kemingy commented Jul 7, 2022

Do we need to run image_publish for all the commits? It seems really slow. I guess it only needs to run for tagged commit?

@gaocegege
Copy link
Member

Do we need to run image_publish for all the commits? It seems really slow. I guess it only needs to run for tagged commit?

SGTM. Could you please update the PR? @VoVAllen

@VoVAllen
Copy link
Member Author

VoVAllen commented Jul 7, 2022

Actually it will be triggered only with tag push as declared at the beginning

on:
  push:
    tags:
      - 'v*'
  pull_request:
    paths:
    - '.github/workflows/release.yml'
    - '.goreleaser/'
    - '.goreleaser.yaml'

Adding startsWith(github.ref, 'refs/tags/v') in pypi_publish is because pypi index can only accept formal tag version name. Commit without hash will be named as v0.1+{commit_id}, which will be rejected by pypi index. This is used to avoid potential errors when modifying other parts of release.yml

@gaocegege
Copy link
Member

SGTM

@gaocegege gaocegege merged commit 4fa5ec7 into tensorchord:main Jul 7, 2022
@terrytangyuan
Copy link
Member

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Invalid workflow file: .github/workflows/release.yml#L57
4 participants