feat(ir): all in llb #941
Merged
feat(ir): all in llb #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kemingy
commented
Sep 27, 2022
kemingy
commented
- fix feat(CD): Deprecate envd base images, use LLB to support envd prerequisite #278
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
kemingy
requested review from
gaocegege,
aseaday,
zwpaper and
VoVAllen
as code owners
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kemingy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Keming <kemingyang@tensorchord.ai>
kemingy
commented
Sep 27, 2022
kemingy
commented
Sep 27, 2022
Comment on lines
+29
to
+30
| username: ${{ secrets.DOCKERIO_USERNAME }} | ||
| password: ${{ secrets.DOCKERIO_TOKEN }} |
There was a problem hiding this comment.
CI failed with "Error: Username and password required".
cc @gaocegege
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
kemingy
commented
Sep 28, 2022
| @@ -69,15 +69,15 @@ changelog: | |||
| - '^chore:' | |||
| dockers: | |||
| - image_templates: | |||
| - "ghcr.io/tensorchord/envd-sshd-from-scratch:{{ .Version }}-amd64" | |||
| - "tensorchord/envd-sshd-from-scratch:v{{ .Version }}-amd64" | |||
There was a problem hiding this comment.
|
This needs to create a release to publish to the docker hub. Already tested in my fork: kemingy#19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.