Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Addons for Windows #173

Closed
seanpmorgan opened this issue Apr 15, 2019 · 29 comments · Fixed by #771
Closed

Build Addons for Windows #173

seanpmorgan opened this issue Apr 15, 2019 · 29 comments · Fixed by #771
Labels
build help wanted Needs help as a contribution

Comments

@seanpmorgan
Copy link
Member

seanpmorgan commented Apr 15, 2019

Splitting this as a separate issue from #77. MacOS should be an achievable goal prior to the 0.3 release. Windows will take a bit longer.

@geometrikal
Copy link

Any progress?

@geometrikal
Copy link

To explain why this is important for Windows users:

If you want to do rotation augmentation, options are either a python library (e.g. numpy) or image rotate from tensorflow addons. Multiprocessing doesn't really work for Windows, e.g. using keras fit_generator with multiprocessing enable will throw an error, so they best (and fastest) way has been to use tf.data.Dataset with mapping via tf.contrib.image.rotate. With TF2.0 contrib has been removed, so until addons works there is no easy way to do parallel rotation augmentation.

@seanpmorgan
Copy link
Member Author

Hi @geometrikal! Thanks for bumping this and explaining the need. There is no progress that I am aware of though the issue is tagged help wanted so perhaps someone else could expedite it.

After we finish the nightly builds I can start working on this issue but it may not be for another month or so. It will certainly be added though as this is high priority per our monthly newsletter.

@svobora
Copy link

svobora commented Jun 25, 2019

I have the same issue as @geometrikal, as I use tf.data.Dataset, map for preprocessing, there is no workaround for data augmentation with rotations. Please look into it.

@geometrikal
Copy link

geometrikal commented Jun 25, 2019

@seanpmorgen The see this has the help-wanted tag. What would be the overall steps required to try to get this running on Windows? Just try build from source or does it need a Windows specific build script?

@seanpmorgan
Copy link
Member Author

@geometrikal I've created an issue in custom-op repo to discuss the current issue and see how we can get this done.

@seanpmorgan seanpmorgan added the blocked Pending something elses completion label Jul 6, 2019
@sbarman25
Copy link

Any update on Windows or Universal binaries for this package? It is much appreciated to target Windows users as well as *NIX systems.

@seanpmorgan
Copy link
Member Author

Hi @sbarman-mi9 we're currently blocked by this issue: tensorflow/custom-op#24

There will need to be some changes on core TensorFlow's side. We'll bring it back up again at this month's meeting to see if we can get some progress. CC @perfinion to see if he has any more information from SIG-Build

@davideboschetto
Copy link

davideboschetto commented Oct 2, 2019

Is there any update to this?
tfa might be quite useful also for windows users :)

@seanpmorgan
Copy link
Member Author

Hi @davideboschetto unfortunately this is blocked until progress is made in the issue linked above:
tensorflow/custom-op#24

We'll update this as information is made available.

@gigadeplex
Copy link

gigadeplex commented Oct 8, 2019

Hi I also ran into this problem just now!! Why even move it to tf addons and not keep it in 2.0??

@consi95
Copy link

consi95 commented Oct 10, 2019

Hello :) i know that this is blocked, but would be really nice if there would be any progress. I am stucked at the same point. I dont want to rewrite my code to older tf versions...

@ChenYang-ChenYang
Copy link
Contributor

The same request there. I'm always waiting from May to now!

@meysamsadeghi
Copy link

I also would like to ask for further action on this issue. It is very useful. Also, is there any workaround suggestion?

@seanpmorgan
Copy link
Member Author

Hi @meysamsadeghi (and others). We're really sorry for this not being implemented yet, but it's outside of the scope of what SIG-Addons is capable of supporting at the moment.

Please forward your request comments/support to the custom-op issue: tensorflow/custom-op#24 so that it can be prioritized. The roadmap has been laid out, but it needs to be completed.

There are a couple of possible work arounds that I see though:

  1. Use Windows Subsystem for Linux (WSL)
  2. As a last resort, you could copy addons operations into a fork of tensorflow/tensorflow core repo and compile the custom-ops alongside the entire framework.

@jkyl
Copy link

jkyl commented Dec 2, 2019

Unfortunately WSL does not enable GPU passthrough. I've bumped tensorflow/custom-op#24 with a plea for increased priority.

@seanpmorgan seanpmorgan removed the blocked Pending something elses completion label Dec 6, 2019
@seanpmorgan
Copy link
Member Author

Thanks to @yifeif this should be unblocked.

@FaraiCH
Copy link

FaraiCH commented Dec 7, 2019

Hi, I'm using Tensorflow 2.0 and I have come to a problem. tf.contrib is not recognized as an attribute and when I try to install tensorflow-addons on my windows machine, it fails. However, it seems to work fine on my Mac. Is there any news or update on this?

@geometrikal
Copy link

@FaraiCH As @seanpmorgan has posted, this is waiting on implementation of custom op in the normal Tensorflow repo. It seems there has been some work done on this so we can be hopeful of some progress soon!

@andreisland
Copy link

Hi. Is it possible to install TF-Addons on Windows 10 now with pip? If not with pip, is it possible to install it from sources in other ways?
Thank you for your help.

@seanpmorgan
Copy link
Member Author

Hi. Is it possible to install TF-Addons on Windows 10 now with pip? If not with pip, is it possible to install it from sources in other ways?
Thank you for your help.

Hi @rawhazard not yet, but we're hoping to have a windows CPU package in the very near future

@drozzy
Copy link

drozzy commented Dec 14, 2019

Please add support for windows. I get cryptic error when trying to install this:

ERROR: Could not find a version that satisfies the requirement tensorflow-addons (from versions: none)
ERROR: No matching distribution found for tensorflow-addons

@mihaimaruseac
Copy link

@drozzy when you get that message you can get more information by trying pip debug verbose and looking at the tags pip gives back to you and comparing with the tags on the pypi page. This works for any python package.

@seanpmorgan
Copy link
Member Author

PR has been merged, expect a windows wheel available for 0.7 release which is waiting on TF2.1. We can't make nightlies for windows as there are no tf-nightly windows builds.

@guillaumekln
Copy link
Contributor

Great news! Thank you very much for your work, Sean!

@tejasdixit
Copy link

tejasdixit commented Dec 19, 2019

So i guess i will need to do it again with tensorflow 2.1 (currently i am using version 1.5 as the file generate_tfrecord.py won't even work with tensorflow 2.0 in windows)

@seanpmorgan
Copy link
Member Author

FYI stable release for windows is out. pip install tensorflow-addons

@tejasdixit
Copy link

tejasdixit commented Jan 10, 2020 via email

@yifeif
Copy link

yifeif commented Jan 13, 2020

Thank you @seanpmorgan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build help wanted Needs help as a contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.