Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tools for standardize formatting & sanity-check #63

Merged
merged 13 commits into from
Mar 4, 2019
Merged

add tools for standardize formatting & sanity-check #63

merged 13 commits into from
Mar 4, 2019

Conversation

facaiy
Copy link
Member

@facaiy facaiy commented Mar 3, 2019 •
edited
Loading

Fix #16

  1. add code_format.sh for autoformatting. See its preview in use code_format.sh to format all files #64 .
  2. migrate ci_sanity.sh from tensorflow/tensorflow.
  3. add makefile, make them easy-to-use. 
    # 0. Format codes automatically
make code-format
# 1. Sanity check
make sanity-check
# 2. Run unit test
make unit-test
# 3. All of the above
make

@facaiy facaiy requested a review from seanpmorgan March 3, 2019 09:18
@facaiy facaiy added the build label Mar 3, 2019
@facaiy facaiy mentioned this pull request Mar 3, 2019
Merged
@facaiy facaiy force-pushed the BLD/auto_format branch 3 times, most recently from 1e6db5a to 6dfdaac Compare March 3, 2019 09:53
@facaiy facaiy added the style Related to repository's style label Mar 3, 2019
@facaiy facaiy self-assigned this Mar 3, 2019
@facaiy facaiy assigned seanpmorgan and unassigned facaiy Mar 3, 2019
facaiy
facaiy commented Mar 3, 2019
View reviewed changes
makefile Show resolved Hide resolved
@facaiy facaiy force-pushed the BLD/auto_format branch 2 times, most recently from 9a85cbc to 011f806 Compare March 3, 2019 12:33
seanpmorgan
seanpmorgan reviewed Mar 4, 2019
View reviewed changes
makefile Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
tools/ci_build/ci_sanity.sh Show resolved Hide resolved
makefile Show resolved Hide resolved
tools/ci_build/builds/builds_common.sh Show resolved Hide resolved
seanpmorgan
seanpmorgan requested changes Mar 4, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks great, thanks as always!

@facaiy
Copy link
Member Author

facaiy commented Mar 4, 2019

Could you take a look again, Sean?

seanpmorgan
seanpmorgan approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@seanpmorgan seanpmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@facaiy facaiy merged commit dfd34c8 into tensorflow:master Mar 4, 2019
@facaiy facaiy deleted the BLD/auto_format branch March 4, 2019 05:14
@facaiy facaiy mentioned this pull request Mar 4, 2019
Closed
Squadrick pushed a commit to Squadrick/addons that referenced this pull request Mar 26, 2019
@facaiy
add tools for standardize formatting & sanity-check (tensorflow#63)
72a3a6b 
* BLD: add auto format and sanity check tools

* BLD: add ci requirements

* CLN: fix bash code style

* ENH: --incremental find files changed from master

* BLD: add install_ci_dependency script

* BLD: add makefile

* CLN: minor fix

* ENH: more robust way to check root dir

* CLN: minor fix

* CLN: replace unit-test by addons_cpu.sh

* BUG: fix, local_config_tf is missing

* DOC: hightlight make commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpmorgan seanpmorgan seanpmorgan approved these changes

@armando-fandango armando-fandango Awaiting requested review from armando-fandango

Assignees

@seanpmorgan seanpmorgan

Labels
build cla: yes style Related to repository's style
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@facaiy @seanpmorgan @googlebot