-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tools for standardize formatting & sanity-check #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e6db5a
to
6dfdaac
Compare
facaiy
commented
Mar 3, 2019
facaiy
commented
Mar 3, 2019
facaiy
commented
Mar 3, 2019
9a85cbc
to
011f806
Compare
seanpmorgan
reviewed
Mar 4, 2019
seanpmorgan
requested changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks great, thanks as always!
Could you take a look again, Sean? |
seanpmorgan
approved these changes
Mar 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Squadrick
pushed a commit
to Squadrick/addons
that referenced
this pull request
Mar 26, 2019
* BLD: add auto format and sanity check tools * BLD: add ci requirements * CLN: fix bash code style * ENH: --incremental find files changed from master * BLD: add install_ci_dependency script * BLD: add makefile * CLN: minor fix * ENH: more robust way to check root dir * CLN: minor fix * CLN: replace unit-test by addons_cpu.sh * BUG: fix, local_config_tf is missing * DOC: hightlight make commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #16
code_format.sh
for autoformatting. See its preview in use code_format.sh to format all files #64 .ci_sanity.sh
from tensorflow/tensorflow.