[WIP] Adding TCN Layers to TFA Layers #672
Conversation
| from tensorflow_addons.utils import keras_utils | ||
|
|
||
|
|
||
| @keras_utils.register_keras_custom_object |
There was a problem hiding this comment.
Could you update this to use the public Keras API:
#669
There was a problem hiding this comment.
got it, will update, thanks @seanpmorgan :)
* CLN: Refactor f_scores and f_test * Add `threshold` param to f-scores * Tests now compare with sklearn * Add sklearn to requirements * Format files * Add F1 score test * Register FBetaScore and F1Score as Keras custom objects * Update readme to separate both metrics * Add test for F1-score get_config * FIX: Use sk_score for true value * Remove sklearn from f_test Resort to using hard coded test cases rather than comparing with sklearn * Remove unused import * Rename test_keras_model -> _get_model
* FIX: Internally cast to required DType * Add pylint disable for unscriptable-object bug
* Remove test skips since upstream fix * Use public keras object registration * Merge master and update registration * Fix tf import * Update READMEs * F scores keras registration * Lint
* fix overflow of int32
shun-lin
requested review from
guillaumekln,
qlzh727,
Squadrick,
WindQAQ and
a team
as code owners
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
closing this PR because I messed up fetching in changes from upstream master again, will open another PR haha. |
[Not Ready for Merge]
This PR adds TCN layer as well as the Residual Block layer to TFA layers.
TODO(shunlin):
Clean up code.
Add more comments / documentations.
Write unit tests.
Make a Colab tutorial.
Associated Issues:
#661
philipperemy/keras-tcn#73
Source Implementations:
https://github.com/philipperemy/keras-tcn (In Pure Keras)
https://github.com/locuslab/TCN (In Pytorch)
Relevant Paper:
https://arxiv.org/pdf/1803.01271.pdf